Bugzilla – Attachment 139916 Details for
Bug 30847
Cleanup opac-reserve.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30847: Remove unused noreserve parameter
Bug-30847-Remove-unused-noreserve-parameter.patch (text/plain), 1.22 KB, created by
Joonas Kylmälä
on 2022-08-28 14:24:44 UTC
(
hide
)
Description:
Bug 30847: Remove unused noreserve parameter
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2022-08-28 14:24:44 UTC
Size:
1.22 KB
patch
obsolete
>From f7c6fc20a071606130f2c670dd5aa41c5a53aab3 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 25 May 2022 14:00:16 +0000 >Subject: [PATCH] Bug 30847: Remove unused noreserve parameter >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This is defined but never used > >To test: >1 - git grep noreserve >2 - only one ocurrence >3 - Apply patch >4 - repeat, no ocurrence >5 - Note the plural has a few uses > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> >--- > opac/opac-reserve.pl | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl >index 2ee0f2f1c7..b71579d8e4 100755 >--- a/opac/opac-reserve.pl >+++ b/opac/opac-reserve.pl >@@ -329,7 +329,6 @@ if ( $query->param('place_reserve') ) { > # > my $noreserves = 0; > my $maxoutstanding = C4::Context->preference("maxoutstanding"); >-$template->param( noreserve => 1 ) unless $maxoutstanding; > my $amountoutstanding = $patron->account->balance; > if ( $amountoutstanding && ($amountoutstanding > $maxoutstanding) ) { > my $amount = sprintf "%.02f", $amountoutstanding; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30847
:
135340
|
135341
|
135342
|
135343
|
135344
|
135345
|
135346
|
135347
|
135348
|
137668
|
137669
|
137670
|
137671
|
137672
|
137673
|
137674
|
137675
|
138654
|
138655
|
138934
|
138935
|
138936
|
138937
|
138938
|
138939
|
138940
|
138941
|
139628
|
139629
|
139630
|
139631
|
139632
|
139633
|
139634
|
139635
|
139915
| 139916 |
139917
|
139918
|
139919
|
139920
|
139921
|
139922
|
139923