Attachment 139919 Details for Bug 30847 – Bug 30847: Avoid fetching biblio object

[patch] Bug 30847: Avoid fetching biblio object

Bug-30847-Avoid-fetching-biblio-object.patch (text/plain), 1.42 KB, created by Joonas Kylmälä on 2022-08-28 14:24:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2022-08-28 14:24:57 UTC

Size: 1.42 KB

patch

obsolete

>From fdf9bb7621d9568e47ec46e964bb66defaa4e475 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 25 May 2022 14:33:26 +0000
>Subject: [PATCH] Bug 30847: Avoid fetching biblio object
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Here the items biblionumber is either equal to the biblionumber passed
>in or it is not and should be - we can just assign directly from the
>item in all cases
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@iki.fi>
>---
> opac/opac-reserve.pl | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
>diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
>index df0582df54..bf7525f2f8 100755
>--- a/opac/opac-reserve.pl
>+++ b/opac/opac-reserve.pl
>@@ -237,12 +237,9 @@ if ( $query->param('place_reserve') ) {
>             }
>         }
> 
>-#item may belong to a host biblio, if yes change biblioNum to hosts bilbionumber
>+        # if we have an item, we are placing the hold on the item's bib, in case of analytics
>         if ( $item ) {
>-            my $hostbiblioNum = $item->biblio->biblionumber;
>-            if ( $hostbiblioNum ne $biblioNum ) {
>-                $biblioNum = $hostbiblioNum;
>-            }
>+            $biblioNum = $item->biblionumber;
>         }
> 
>         my $biblioData = $biblioDataHash{$biblioNum};
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30847: 135340 | 135341 | 135342 | 135343 | 135344 | 135345 | 135346 | 135347 | 135348 | 137668 | 137669 | 137670 | 137671 | 137672 | 137673 | 137674 | 137675 | 138654 | 138655 | 138934 | 138935 | 138936 | 138937 | 138938 | 138939 | 138940 | 138941 | 139628 | 139629 | 139630 | 139631 | 139632 | 139633 | 139634 | 139635 | 139915 | 139916 | 139917 | 139918 | 139919 | 139920 | 139921 | 139922 | 139923