Attachment 139920 Details for Bug 30847 – Bug 30847: Don't declare undef variable for assignment

[patch] Bug 30847: Don't declare undef variable for assignment

Bug-30847-Dont-declare-undef-variable-for-assignme.patch (text/plain), 1.38 KB, created by Joonas Kylmälä on 2022-08-28 14:25:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2022-08-28 14:25:02 UTC

Size: 1.38 KB

patch

obsolete

>From aad96ff83bd77e53a7254c24edf2cf24cc7963c1 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 25 May 2022 14:34:55 +0000
>Subject: [PATCH] Bug 30847: Don't declare undef variable for assignment
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>New holds have found set to undef - we can do this directly
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@iki.fi>
>---
> opac/opac-reserve.pl | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
>index bf7525f2f8..30fa544267 100755
>--- a/opac/opac-reserve.pl
>+++ b/opac/opac-reserve.pl
>@@ -243,7 +243,6 @@ if ( $query->param('place_reserve') ) {
>         }
> 
>         my $biblioData = $biblioDataHash{$biblioNum};
>-        my $found;
> 
>         # Check for user supplied reserve date
>         my $startdate;
>@@ -299,7 +298,7 @@ if ( $query->param('place_reserve') ) {
>                     notes            => $notes,
>                     title            => $biblioData->{title},
>                     itemnumber       => $itemNum,
>-                    found            => $found,
>+                    found            => undef,
>                     itemtype         => $itemtype,
>                 }
>             );
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30847: 135340 | 135341 | 135342 | 135343 | 135344 | 135345 | 135346 | 135347 | 135348 | 137668 | 137669 | 137670 | 137671 | 137672 | 137673 | 137674 | 137675 | 138654 | 138655 | 138934 | 138935 | 138936 | 138937 | 138938 | 138939 | 138940 | 138941 | 139628 | 139629 | 139630 | 139631 | 139632 | 139633 | 139634 | 139635 | 139915 | 139916 | 139917 | 139918 | 139919 | 139920 | 139921 | 139922 | 139923