Attachment 140008 Details for Bug 29697 – Bug 29697: (QA follow-up) Remove useless warning

[patch] Bug 29697: (QA follow-up) Remove useless warning

Bug-29697-QA-follow-up-Remove-useless-warning.patch (text/plain), 1016 bytes, created by Tomás Cohen Arazi (tcohen) on 2022-08-31 15:35:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-08-31 15:35:46 UTC

Size: 1016 bytes

patch

obsolete

>From 8bd4edebf9df64b3c84163bc0610d33f6a2c327f Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Wed, 31 Aug 2022 12:34:39 -0300
>Subject: [PATCH] Bug 29697: (QA follow-up) Remove useless warning
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> t/db_dependent/Search.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Search.t b/t/db_dependent/Search.t
>index 5c34356ac8..faa590bba5 100755
>--- a/t/db_dependent/Search.t
>+++ b/t/db_dependent/Search.t
>@@ -491,7 +491,7 @@ ok(MARC::Record::new_from_xml($results_hashref->{biblioserver}->{RECORDS}->[0],'
>     like( $newresults[0]->{XSLTResultsRecord}, qr/<variable name="anonymous_session">1<\/variable>/, "Variable injected correctly" );
> 
>     my $biblio_id = $newresults[0]->{biblionumber};
>-    my $fw = C4::Biblio::GetFrameworkCode($biblio_id);
>+    my $fw = C4::Biblio::GetFrameworkCode($biblio_id) // '';
> 
>     my $dbh = C4::Context->dbh;
>     # FIXME This change is revert in END
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 29697: 129757 | 129758 | 129759 | 129760 | 129761 | 131868 | 131869 | 131870 | 131871 | 131872 | 131873 | 134066 | 134067 | 134068 | 134069 | 134070 | 134071 | 135574 | 135575 | 135576 | 135577 | 135578 | 135579 | 135580 | 135662 | 135663 | 135664 | 135665 | 135666 | 135667 | 135668 | 135669 | 135670 | 135671 | 135672 | 135673 | 135797 | 135798 | 135799 | 135800 | 135801 | 135802 | 135978 | 135979 | 135980 | 135981 | 135982 | 137835 | 137836 | 137837 | 137838 | 137839 | 137840 | 137894 | 137918 | 137919 | 137920 | 137921 | 137922 | 137923 | 137924 | 137948 | 138057 | 138076 | 138077 | 138078 | 138079 | 138080 | 138081 | 138089 | 138090 | 138804 | 139127 | 140007 | 140008