Attachment 14004 Details for Bug 6918 – Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off

[patch] Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off

Bug-6918---cant-place-holds-on-on-order-items-with.patch (text/plain), 1.11 KB, created by Kyle M Hall (khall) on 2012-12-11 16:12:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2012-12-11 16:12:16 UTC

Size: 1.11 KB

patch

obsolete

>From 5630ef2a763486d24e158ba6be239d3384d6fc90 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 11 Dec 2012 11:09:49 -0500
>Subject: [PATCH] Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off
>
>Koha documenation suggests that NOT_LOAN values less than 0 should be
>hold-able. This patch enables that.
>
>From the manual:
>Negative number values will still allow holds (use for on order statuses for example)
>where as positive numbers will not allow holds or checkouts
>---
> C4/Reserves.pm |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index a380bf0..ed51fc0 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -1441,7 +1441,7 @@ sub IsAvailableForItemLevelRequest {
>     if (C4::Context->preference('AllowOnShelfHolds')) {
>         return $available_per_item;
>     } else {
>-        return ($available_per_item and ($item->{onloan} or GetReserveStatus($itemnumber) eq "W")); 
>+        return ($available_per_item and ($item->{onloan} or GetReserveStatus($itemnumber) eq "W" or $item->{notforloan} < 0)); 
>     }
> }
> 
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 6918: 14004 | 14152 | 14158 | 14390 | 14451 | 15077 | 19087 | 68898 | 68934 | 70232 | 102998 | 103016 | 103020 | 103021 | 103175 | 103179 | 105390 | 105473 | 105474