Bugzilla – Attachment 140067 Details for
Bug 28290
Record matching rules with no subfields cause ISE
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28290: (follow-up) Unit test
Bug-28290-follow-up-Unit-test.patch (text/plain), 1.23 KB, created by
Nick Clemens (kidclamp)
on 2022-09-02 06:40:28 UTC
(
hide
)
Description:
Bug 28290: (follow-up) Unit test
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-09-02 06:40:28 UTC
Size:
1.23 KB
patch
obsolete
>From e5febacc15ed1f4363fcf68ea0095c1b24a22b65 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 2 Sep 2022 06:39:39 +0000 >Subject: [PATCH] Bug 28290: (follow-up) Unit test > >--- > t/Matcher.t | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > >diff --git a/t/Matcher.t b/t/Matcher.t >index 3345e14251..2c7b288769 100755 >--- a/t/Matcher.t >+++ b/t/Matcher.t >@@ -82,7 +82,7 @@ is( $testmatcher->description(), 'match on ISSN', 'testing code accessor' ); > > subtest '_get_match_keys() tests' => sub { > >- plan tests => 20; >+ plan tests => 21; > > my $matchpoint = get_title_matchpoint({ > length => 0, >@@ -262,6 +262,13 @@ subtest '_get_match_keys() tests' => sub { > is( $keys[2], '1NOTISBN3', > 'Match key passed through if not an isbn when ISBN normalizer used'); > >+ $matchpoint = get_title_matchpoint({ >+ length => 0, >+ offset => 0 >+ }); >+ delete $matchpoint->{component}->{subfields}; >+ @keys = C4::Matcher::_get_match_keys( $record, $matchpoint ); >+ is( $keys[0], ' .; thE t[]:,aliS(m)/An\'" Stephen King, Peter Straub.', "Match key correctly returns whole field if no subfields specified" ) > }; > > subtest '_get_match_keys() leader tests' => sub { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28290
:
120474
|
120475
|
120686
|
120827
|
120828
|
140066
|
140067
|
140263
|
140264