Bugzilla – Attachment 14008 Details for
Bug 9076
Add ability to delete borrowers by expiration date and category code to cleanborrowers.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9076 - QA Followup - Rename GetBorrowersWhoHaveNotBorrowedSince to GetBorrowersToExpunge
Bug-9076---QA-Followup---Rename-GetBorrowersWhoHav.patch (text/plain), 3.31 KB, created by
Kyle M Hall (khall)
on 2012-12-11 19:08:19 UTC
(
hide
)
Description:
Bug 9076 - QA Followup - Rename GetBorrowersWhoHaveNotBorrowedSince to GetBorrowersToExpunge
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2012-12-11 19:08:19 UTC
Size:
3.31 KB
patch
obsolete
>From bdfd090e5713d1be3ccc233beb1f31a2a5510428 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 11 Dec 2012 14:07:48 -0500 >Subject: [PATCH] Bug 9076 - QA Followup - Rename GetBorrowersWhoHaveNotBorrowedSince to GetBorrowersToExpunge > >--- > C4/Members.pm | 8 ++++---- > t/db_dependent/lib/KohaTest/Members.pm | 2 +- > tools/cleanborrowers.pl | 4 ++-- > 3 files changed, 7 insertions(+), 7 deletions(-) > >diff --git a/C4/Members.pm b/C4/Members.pm >index 263e06c..d8e627f 100644 >--- a/C4/Members.pm >+++ b/C4/Members.pm >@@ -88,7 +88,7 @@ BEGIN { > GetBorrowerCategorycode > &GetBorrowercategoryList > >- &GetBorrowersWhoHaveNotBorrowedSince >+ &GetBorrowersToExpunge > &GetBorrowersWhoHaveNeverBorrowed > &GetBorrowersWithIssuesHistoryOlderThan > >@@ -1922,9 +1922,9 @@ WHERE roadtypeid=?|; > return ($roadtype); > } > >-=head2 GetBorrowersWhoHaveNotBorrowedSince >+=head2 GetBorrowersToExpunge > >- $borrowers = &GetBorrowersWhoHaveNotBorrowedSince( >+ $borrowers = &GetBorrowersToExpunge( > not_borrowered_since => $not_borrowered_since, > expired_before => $expired_before, > category_code => $category_code, >@@ -1935,7 +1935,7 @@ WHERE roadtypeid=?|; > > =cut > >-sub GetBorrowersWhoHaveNotBorrowedSince { >+sub GetBorrowersToExpunge { > my $params = shift; > > my $filterdate = $params->{'not_borrowered_since'}; >diff --git a/t/db_dependent/lib/KohaTest/Members.pm b/t/db_dependent/lib/KohaTest/Members.pm >index dfde7da..35e6e30 100644 >--- a/t/db_dependent/lib/KohaTest/Members.pm >+++ b/t/db_dependent/lib/KohaTest/Members.pm >@@ -48,7 +48,7 @@ sub methods : Test( 1 ) { > GetPatronImage > PutPatronImage > RmPatronImage >- GetBorrowersWhoHaveNotBorrowedSince >+ GetBorrowersToExpunge > GetBorrowersWhoHaveNeverBorrowed > GetBorrowersWithIssuesHistoryOlderThan > GetBorrowersNamesAndLatestIssue >diff --git a/tools/cleanborrowers.pl b/tools/cleanborrowers.pl >index 6a30326..e350b9d 100755 >--- a/tools/cleanborrowers.pl >+++ b/tools/cleanborrowers.pl >@@ -78,7 +78,7 @@ if ( $params->{'step2'} ) { > my $membersToDelete; > if ( $checkboxes{borrower} ) { > $membersToDelete = >- GetBorrowersWhoHaveNotBorrowedSince( { not_borrowered_since => $filterdate1, expired_before => $borrower_dateexpiry, category_code => $borrower_categorycode } ); >+ GetBorrowersToExpunge( { not_borrowered_since => $filterdate1, expired_before => $borrower_dateexpiry, category_code => $borrower_categorycode } ); > $totalDel = scalar @$membersToDelete; > > } >@@ -120,7 +120,7 @@ if ( $params->{'step3'} ) { > # delete members > if ($do_delete) { > my $membersToDelete = >- GetBorrowersWhoHaveNotBorrowedSince( { not_borrowered_since => $filterdate1, expired_before => $borrower_dateexpiry, category_code => $borrower_categorycode } ); >+ GetBorrowersToExpunge( { not_borrowered_since => $filterdate1, expired_before => $borrower_dateexpiry, category_code => $borrower_categorycode } ); > $totalDel = scalar(@$membersToDelete); > $radio = $params->{'radio'}; > if ( $radio eq 'trash' ) { >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9076
:
13449
|
13450
|
13491
|
13492
|
13541
|
13542
|
13551
|
13552
|
14008
|
14406
|
14407
|
14408
|
14409