Attachment 140155 Details for Bug 31399 – Bug 31399: Set focus on first input when adding a new classification source, filing rule, or splitting rule

[patch] Bug 31399: Set focus on first input when adding a new classification source, filing rule, or splitting rule

Bug-31399-Set-focus-on-first-input-when-adding-a-n.patch (text/plain), 4.12 KB, created by Kyle M Hall (khall) on 2022-09-02 14:34:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2022-09-02 14:34:34 UTC

Size: 4.12 KB

patch

obsolete

>From 28ab0d99f19bd68d4c1d981498756b770e5dc455 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Thu, 18 Aug 2022 20:48:44 +0000
>Subject: [PATCH] Bug 31399: Set focus on first input when adding a new
> classification source, filing rule, or splitting rule
>
>This makes sure the cursor/focus is always in the first form
>field when adding an entry on the classification configuration page.
>
>* Got to administration > classification sources
>* Verify for each of the three "New ..." buttons on top that
>  the entry form has no focus on any field
>* Apply patch
>* Repeat testing the new forms and the focus now should always
>  be in the first input field of the entry form
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> .../prog/en/modules/admin/classsources.tt            | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt
>index b2fbe881bd..c8af609983 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt
>@@ -161,12 +161,12 @@ Classification sources &rsaquo; Administration &rsaquo; Koha
>     <ol>
>       <li>
>           [% IF class_source %]
>-		  <span class="label">Classification source code: </span>
>+            <span class="label">Classification source code: </span>
>             <input type="hidden" name="cn_source" value="[% class_source.cn_source | html %]" />
>             [% class_source.cn_source | html %]
>           [% ELSE %]
>               <label class="required" for="class_source">Classification source code: </label>
>-              <input class="required" required="required" type="text" id="class_source" name="cn_source"  size="10" maxlength="10" />
>+              <input class="required focus" required="required" type="text" id="class_source" name="cn_source"  size="10" maxlength="10" />
>               <span class="required">Required</span>
>           [% END %]
>        </li>
>@@ -176,7 +176,7 @@ Classification sources &rsaquo; Administration &rsaquo; Koha
>        </li>
>        <li><label for="used">Source in use?</label>
>            [% IF ( class_source.used ) %]<input type="checkbox" id="used" name="used" value="used" checked="checked" />[% ELSE %]
>-		  <input type="checkbox" id="used" name="used" value="used" />[% END %]
>+           <input type="checkbox" id="used" name="used" value="used" />[% END %]
>        </li>
>         <li>
>             <label class="required" for="class_sort_rule">Filing rule: </label>
>@@ -225,12 +225,12 @@ Classification sources &rsaquo; Administration &rsaquo; Koha
>     <ol>
>       <li>
>           [% IF sort_rule %]
>-		  <span class="label">Filing rule code: </span>
>+          <span class="label">Filing rule code: </span>
>             <input type="hidden" name="class_sort_rule" value="[% sort_rule.class_sort_rule | html %]" />
>             [% sort_rule.class_sort_rule | html %]
>           [% ELSE %]
>               <label for="class_sort_rule" class="required">Filing rule code: </label>
>-              <input class="required" required="required" type="text" id="class_sort_rule" name="class_sort_rule"  size="10" maxlength="10" />
>+              <input class="required focus" required="required" type="text" id="class_sort_rule" name="class_sort_rule"  size="10" maxlength="10" />
>               <span class="required">Required</span>
>           [% END %]
>        </li>
>@@ -276,7 +276,7 @@ Classification sources &rsaquo; Administration &rsaquo; Koha
>             [% split_rule.class_split_rule | html %]
>           [% ELSE %]
>               <label for="class_split_rule" class="required">Splitting rule code: </label>
>-              <input class="required" required="required" type="text" id="class_split_rule" name="class_split_rule"  size="10" maxlength="10" />
>+              <input class="required focus" required="required" type="text" id="class_split_rule" name="class_split_rule"  size="10" maxlength="10" />
>               <span class="required">Required</span>
>           [% END %]
>        </li>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31399: 139428 | 139430 | 140155