Bugzilla – Attachment 140161 Details for
Bug 27081
Notes missing from lost items report column configuration when CSV export is active
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27081: Handle first column (checkboxes) in column settings for lost items report
Bug-27081-Handle-first-column-checkboxes-in-column.patch (text/plain), 1.81 KB, created by
Kyle M Hall (khall)
on 2022-09-02 15:27:38 UTC
(
hide
)
Description:
Bug 27081: Handle first column (checkboxes) in column settings for lost items report
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2022-09-02 15:27:38 UTC
Size:
1.81 KB
patch
obsolete
>From 05f0204b67d15a82596f4b2ca5655fc10e0394a2 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 10 Aug 2022 16:36:28 +0200 >Subject: [PATCH] Bug 27081: Handle first column (checkboxes) in column > settings for lost items report > >We are adding one column (the one with the checkboxes) at the beginning >of each row if it's possible to export the report to CSV. >However the column settings were not modified. We need to append one >object representing this column. > >Test plan: >To test: >* Create a CSV profile of type SQL for exporting lost items >* Make sure you have some lost items >* Run Reports > Items lost >=> You can hide the notes (last column) > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt >index 9ccc075100..04744426b6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt >@@ -212,6 +212,11 @@ > <script> > $(document).ready(function() { > var table_settings = [% TablesSettings.GetTableSettings( 'reports', 'lostitems', 'lostitems-table', 'json' ) | $raw %]; >+ [% IF csv_profiles.count %] >+ // Add the first (checkbox) column if it is displayed >+ table_settings['columns'].unshift({cannot_be_modified: 1, cannot_be_toggled: 1, columnname: 'itemnumber', is_hidden: 0}); >+ [% END %] >+ > var lostitems_table = KohaTable("lostitems-table", { > "aaSorting": [], > "aoColumnDefs": [ >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27081
:
139001
|
139561
| 140161