Attachment 140178 Details for Bug 31516 – Bug 31516: Add error message for viewing enrollments for a non-existent club

[patch] Bug 31516: Add error message for viewing enrollments for a non-existent club

Bug-31516-Add-error-message-for-viewing-enrollment.patch (text/plain), 1.63 KB, created by Joonas Kylmälä on 2022-09-02 18:48:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2022-09-02 18:48:48 UTC

Size: 1.63 KB

patch

obsolete

>From a97ba699b3a8c5312e067b433e6e8e4702d40fd7 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi>
>Date: Fri, 2 Sep 2022 18:44:24 +0000
>Subject: [PATCH] Bug 31516: Add error message for viewing enrollments for a
> non-existent club
>
>To test:
> 1) Go to non-existent club's enrollment page, e.g.
>    http://localhost:8081/cgi-bin/koha/clubs/club-enrollments.pl?id=1010101001000
> 2) Notice the not fully filled header text and empty table
> 3) Apply patch and revisit the page to see the proper error message given
>---
> .../intranet-tmpl/prog/en/modules/clubs/club-enrollments.tt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/club-enrollments.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/club-enrollments.tt
>index 4383291728..76b3a9bf77 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/club-enrollments.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/club-enrollments.tt
>@@ -36,9 +36,12 @@
>     <div class="row">
>         <div class="col-sm-10 col-sm-push-2">
>             <main>
>-
>+                [% IF !club %]
>+                <div class="dialog message">The club you requested does not exist.</div>
>+                [% ELSE %]
>                 <h1>Club enrollments for <em>[% club.name | html %]</em></h1>
> 
>+
>                 <table id="enrollments-table">
>                     <thead>
>                         <tr>
>@@ -61,6 +64,7 @@
>                         [% END %]
>                     </tbody>
>                 </table>
>+                [% END %]
> 
>             </main>
>         </div> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31516: 140178 | 140179 | 140326 | 140475