Bugzilla – Attachment 140205 Details for
Bug 27421
Porting tools/stage-marc-import.pl to BackgroundJob
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27421: (QA follow-up) Sub finish should respect failed status too
Bug-27421-QA-follow-up-Sub-finish-should-respect-f.patch (text/plain), 935 bytes, created by
Marcel de Rooy
on 2022-09-05 12:13:53 UTC
(
hide
)
Description:
Bug 27421: (QA follow-up) Sub finish should respect failed status too
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2022-09-05 12:13:53 UTC
Size:
935 bytes
patch
obsolete
>From e618657d327230c8fbf78950312051665b73df86 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 5 Sep 2022 10:33:01 +0000 >Subject: [PATCH] Bug 27421: (QA follow-up) Sub finish should respect failed > status too >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/BackgroundJob.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/BackgroundJob.pm b/Koha/BackgroundJob.pm >index d146c38aad..98e22e2c62 100644 >--- a/Koha/BackgroundJob.pm >+++ b/Koha/BackgroundJob.pm >@@ -246,7 +246,7 @@ Makes the job record as finished. If the job status is I<cancelled>, it is kept. > sub finish { > my ( $self, $data ) = @_; > >- $self->status('finished') unless $self->status eq 'cancelled'; >+ $self->status('finished') unless $self->status eq 'cancelled' or $self->status eq 'failed'; > > return $self->set( > { >-- >2.20.1
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=140205">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27421
:
136127
|
136128
|
136129
|
136216
|
136217
|
136338
|
136339
|
138642
|
138643
|
138656
|
138657
|
138660
|
138881
|
139384
|
139385
|
139386
|
139387
|
139388
|
139448
|
139449
|
139450
|
139797
|
140205
|
140206
|
140207
|
140208
|
140223
|
140224
|
140225
|
140226
|
140227
|
140228
|
140229
|
140230
|
140231
|
140232
|
140233
|
140234
|
140759