Bugzilla – Attachment 140260 Details for
Bug 31435
"Configure this table" appears for non-configurable tables
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31435: Tie 'Configure' to table_settings
Bug-31435-Tie-Configure-to-tablesettings.patch (text/plain), 1.84 KB, created by
Martin Renvoize (ashimema)
on 2022-09-07 07:20:59 UTC
(
hide
)
Description:
Bug 31435: Tie 'Configure' to table_settings
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-09-07 07:20:59 UTC
Size:
1.84 KB
patch
obsolete
>From e19d77a2f44ff64a4227c40539945ec49f960418 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 22 Aug 2022 08:15:34 +0100 >Subject: [PATCH] Bug 31435: Tie 'Configure' to table_settings > >This patch adds a check for table_settings to prevent the display of >'Configure this table' when table settings are not passed to the >datatable wrapper. >--- > koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/js/datatables.js | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >index 332868f370..8df6eb56cc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >@@ -161,7 +161,7 @@ function KohaTable(id_selector, dt_parameters, table_settings, add_filters) { > } > ); > >- if ( CAN_user_parameters_manage_column_config ) { >+ if ( table_settings && CAN_user_parameters_manage_column_config ) { > dt_parameters[ "buttons" ].push( > { > className: "dt_button_configure_table", >diff --git a/koha-tmpl/intranet-tmpl/prog/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/js/datatables.js >index f4247ae343..f6b079c794 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/datatables.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/datatables.js >@@ -813,7 +813,7 @@ jQuery.fn.dataTable.ext.errMode = function(settings, note, message) { > } > ); > >- if ( CAN_user_parameters_manage_column_config ) { >+ if ( table_settings && CAN_user_parameters_manage_column_config ) { > settings[ "buttons" ].push( > { > className: "dt_button_configure_table", >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31435
:
139567
|
139570
|
140209
|
140210
|
140211
|
140260
|
140261
|
140265
|
140266
|
140318
|
140319
|
140320