Bugzilla – Attachment 140266 Details for
Bug 31435
"Configure this table" appears for non-configurable tables
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31435: (follow-up) Make kohaTable calls consistent
Bug-31435-follow-up-Make-kohaTable-calls-consisten.patch (text/plain), 3.13 KB, created by
Katrin Fischer
on 2022-09-07 09:32:03 UTC
(
hide
)
Description:
Bug 31435: (follow-up) Make kohaTable calls consistent
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-09-07 09:32:03 UTC
Size:
3.13 KB
patch
obsolete
>From 0fded2276def52111eb5d787edbdb6f33adab5ee Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 5 Sep 2022 13:59:57 +0100 >Subject: [PATCH] Bug 31435: (follow-up) Make kohaTable calls consistent > >Our calls to instantiate a kohaTable from JS were inconsistent in how >they pass table_settings where no table_settings exist. > >This patch replaces empty arrays and empty hashrefs with a consistent >'null' being passed to ake it clear we don't have any settings to pass >yet. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >index eb3ea035ae..93d61a7907 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >@@ -640,7 +640,7 @@ > "searchable": false > } > ] >- }, {}, 1, {"basket.vendor_id": [% booksellerid | html %]}); >+ }, null, 1, {"basket.vendor_id": [% booksellerid | html %]}); > > $(".previewData").on("click", function(e){ > e.preventDefault(); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt >index ae78a07dad..68fbe0f01a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt >@@ -383,7 +383,7 @@ > $(row).addClass('debug'); > } > }, >- }); >+ }, null, 0); > > $('#smtp_servers').on( "click", '.delete_server', function () { > var smtp_server_id = $(this).data('smtp-server-id'); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt >index f19fe43682..0b84adbec2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt >@@ -460,7 +460,7 @@ > "orderable": false > } > ] >- }, [], 1); >+ }, null, 1); > </script> > [% END %] > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt >index 01878722a3..b8ad34f6c5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt >@@ -213,7 +213,7 @@ > "orderable": false > }, > ] >- }); >+ }, null, 0); > > $('#quotes').on( "click", '.delete_quote', function () { > var quote_id = decodeURIComponent($(this).data('quote-id')); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31435
:
139567
|
139570
|
140209
|
140210
|
140211
|
140260
|
140261
|
140265
|
140266
|
140318
|
140319
|
140320