Attachment 140268 Details for Bug 31518 – Bug 31518: Fix syntax error on request.tt that prevents showing hidden item count

[patch] Bug 31518: Fix syntax error on request.tt that prevents showing hidden item count

Bug-31518-Fix-syntax-error-on-requesttt-that-preve.patch (text/plain), 1.95 KB, created by Katrin Fischer on 2022-09-07 10:28:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2022-09-07 10:28:01 UTC

Size: 1.95 KB

patch

obsolete

>From 6ee9b1479d1764fe763ccc552c45ea626948b965 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi>
>Date: Sun, 4 Sep 2022 10:22:22 +0300
>Subject: [PATCH] Bug 31518: Fix syntax error on request.tt that prevents
> showing hidden item count
>
>The variable set by request.pl doesn't have biblio prefix, it is just
>hiddencount.
>
>To test:
> 1) Log in with a staff member account that has "Lost items in staff
> interface" setting set to "Hidden by default" in the patron category
> settings
> 2) Add a lost item to biblio
> 3) Go place a hold on staff interface (request.pl) notice the broken
> link on the request page: "Show all items ( hidden)"
> 4) After applying the patch it should read "Show all items (1 hidden)"
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index eb37dbc00e..0ed253f766 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -859,7 +859,7 @@
>                             [% IF hiddencount %]
>                                 <form>
>                                     <p class="hiddencount">
>-                                        <a href="request.pl?biblionumber=[% biblio.biblionumber | uri %]&amp;borrowernumber=[% borrowernumber | uri %]&amp;showallitems=1">Show all items ([% biblio.hiddencount | html %] hidden)</a>
>+                                        <a href="request.pl?biblionumber=[% biblio.biblionumber | uri %]&amp;borrowernumber=[% borrowernumber | uri %]&amp;showallitems=1">Show all items ([% hiddencount | html %] hidden)</a>
>                                     </p>
>                                 </form>
>                             [% END # /IF hiddencount %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31518: 140198 | 140268