Attachment 140279 Details for Bug 31404 – Bug 31404: (QA follow-up) Mostly whitespace fixes

[patch] Bug 31404: (QA follow-up) Mostly whitespace fixes

Bug-31404-QA-follow-up-Mostly-whitespace-fixes.patch (text/plain), 6.97 KB, created by Katrin Fischer on 2022-09-07 12:41:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2022-09-07 12:41:18 UTC

Size: 6.97 KB

patch

obsolete

>From de6cf0022760e0c6f842c9332e44fb4882864f0d Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Wed, 7 Sep 2022 12:37:39 +0000
>Subject: [PATCH] Bug 31404: (QA follow-up) Mostly whitespace fixes
>
>* Removed the leading space from the new entries as this could
>  lead to another string to translate and they are not needed
>* Removed some doubled up whitespaces from the <a> tags and
>  a stray -
>* Removed title from Article requests since it was the same text
>  as the link itself, not adding information
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../prog/en/includes/circ-nav.inc             | 40 +++++++++----------
> 1 file changed, 20 insertions(+), 20 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc
>index 4b0d15f9ce..61d82953b4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc
>@@ -17,9 +17,9 @@
>             [% UNLESS IndependentBranches %]
>             <li>
>                 [% IF Koha.Preference('UseCirculationDesks') %]
>-                <a href="/cgi-bin/koha/circ/set-library.pl"> Set library and desk</a>
>+                <a href="/cgi-bin/koha/circ/set-library.pl">Set library and desk</a>
>                 [% ELSE %]
>-                <a href="/cgi-bin/koha/circ/set-library.pl"> Set library</a>
>+                <a href="/cgi-bin/koha/circ/set-library.pl">Set library</a>
>                 [% END %]
>             </li>
>             [% END %]
>@@ -30,12 +30,12 @@
>             [% END %]
>             [% IF ( Koha.Preference('AllowCheckoutNotes') && CAN_user_circulate_manage_checkout_notes ) %]
>             <li>
>-                <a href="/cgi-bin/koha/circ/checkout-notes.pl"> Checkout notes</a>
>+                <a href="/cgi-bin/koha/circ/checkout-notes.pl">Checkout notes</a>
>             </li>
>             [% END %]
>             [% IF Koha.Preference('OnSiteCheckouts') %]
>             <li>
>-                <a href="/cgi-bin/koha/circ/on-site_checkouts.pl"> Pending on-site checkouts</a>
>+                <a href="/cgi-bin/koha/circ/on-site_checkouts.pl">Pending on-site checkouts</a>
>             </li>
>             [% END %]
>         </ul>
>@@ -43,21 +43,21 @@
>         <h5>Holds</h5>
>         <ul>
>             <li>
>-                <a  href="/cgi-bin/koha/circ/view_holdsqueue.pl"> Holds queue</a>
>+                <a href="/cgi-bin/koha/circ/view_holdsqueue.pl">Holds queue</a>
>             </li>
>             <li>
>-                <a href="/cgi-bin/koha/circ/pendingreserves.pl"> Holds to pull</a>
>+                <a href="/cgi-bin/koha/circ/pendingreserves.pl">Holds to pull</a>
>             </li>
>             <li>
>-                <a  href="/cgi-bin/koha/circ/waitingreserves.pl"> Holds awaiting pickup</a>
>+                <a href="/cgi-bin/koha/circ/waitingreserves.pl">Holds awaiting pickup</a>
>             </li>
>             [% IF ( Koha.Preference('CurbsidePickup') && CAN_user_circulate_manage_curbside_pickups ) %]
>             <li>
>-                <a  href="/cgi-bin/koha/circ/curbside_pickups.pl"> Curbside pickups</a>
>+                <a href="/cgi-bin/koha/circ/curbside_pickups.pl">Curbside pickups</a>
>             </li>
>             [% END %]
>             <li>
>-                <a - href="/cgi-bin/koha/circ/reserveratios.pl"> Hold ratios</a>
>+                <a href="/cgi-bin/koha/circ/reserveratios.pl">Hold ratios</a>
>             </li>
>         </ul>
> 
>@@ -65,19 +65,19 @@
>         <h5>Recalls</h5>
>         <ul>
>             <li>
>-                <a href="/cgi-bin/koha/recalls/recalls_queue.pl" title="All active recalls"> Recalls queue</a>
>+                <a href="/cgi-bin/koha/recalls/recalls_queue.pl" title="All active recalls">Recalls queue</a>
>             </li>
>             <li>
>-                <a href="/cgi-bin/koha/recalls/recalls_to_pull.pl" title="Recalls that could be filled but have not been set waiting"> Recalls to pull</a>
>+                <a href="/cgi-bin/koha/recalls/recalls_to_pull.pl" title="Recalls that could be filled but have not been set waiting">Recalls to pull</a>
>             </li>
>             <li>
>-                <a href="/cgi-bin/koha/recalls/recalls_overdue.pl" title="Recalled items that are overdue to be returned"> Overdue recalls</a>
>+                <a href="/cgi-bin/koha/recalls/recalls_overdue.pl" title="Recalled items that are overdue to be returned">Overdue recalls</a>
>             </li>
>             <li>
>-                <a href="/cgi-bin/koha/recalls/recalls_waiting.pl" title="Recalled items awaiting pickup"> Recalls awaiting pickup</a>
>+                <a href="/cgi-bin/koha/recalls/recalls_waiting.pl" title="Recalled items awaiting pickup">Recalls awaiting pickup</a>
>             </li>
>             <li>
>-                <a href="/cgi-bin/koha/recalls/recalls_old_queue.pl" title="Inactive recalls"> Old recalls</a>
>+                <a href="/cgi-bin/koha/recalls/recalls_old_queue.pl" title="Inactive recalls">Old recalls</a>
>             </li>
>         </ul>
>         [% END %]
>@@ -86,7 +86,7 @@
>         <h5>Patron request</h5>
>         <ul>
>             <li>
>-                <a href="/cgi-bin/koha/circ/article-requests.pl" title="Article requests"> Article requests</a>
>+                <a href="/cgi-bin/koha/circ/article-requests.pl">Article requests</a>
>             </li>
>         </ul>
>         [% END %]
>@@ -95,14 +95,14 @@
>         <ul>
>         [% IF !Koha.Preference('IndependentBranchesTransfers') || CAN_user_superlibrarian %]
>             <li>
>-                <a href="/cgi-bin/koha/circ/branchtransfers.pl"> Transfer</a>
>+                <a href="/cgi-bin/koha/circ/branchtransfers.pl">Transfer</a>
>             </li>
>         [% END %]
>              <li>
>-                <a href="/cgi-bin/koha/circ/transfers_to_send.pl"> Transfers to send</a>
>+                <a href="/cgi-bin/koha/circ/transfers_to_send.pl">Transfers to send</a>
>             </li>
>             <li>
>-                <a href="/cgi-bin/koha/circ/transferstoreceive.pl"> Transfers to receive</a>
>+                <a href="/cgi-bin/koha/circ/transferstoreceive.pl">Transfers to receive</a>
>             </li>
>         </ul>
> 
>@@ -110,11 +110,11 @@
>         <ul>
>             [% IF ( CAN_user_circulate_overdues_report ) %]
>             <li>
>-                <a href="/cgi-bin/koha/circ/overdue.pl" title="Warning: This report is very resource intensive on systems with large numbers of overdue items."> Overdues</a>
>+                <a href="/cgi-bin/koha/circ/overdue.pl" title="Warning: This report is very resource intensive on systems with large numbers of overdue items.">Overdues</a>
>             </li>
>             [% END %]
>             <li>
>-                <a href="/cgi-bin/koha/circ/branchoverdues.pl" title="Limited to your library.  See report help for other details."> Overdues with fines</a>
>+                <a href="/cgi-bin/koha/circ/branchoverdues.pl" title="Limited to your library. See report help for other details.">Overdues with fines</a>
>              </li>
>         </ul>
>     </div>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31404: 140006 | 140167 | 140278 | 140279