Attachment 140475 Details for Bug 31516 – Bug 31516: Add error message for viewing enrollments for a non-existent club

[patch] Bug 31516: Add error message for viewing enrollments for a non-existent club

Bug-31516-Add-error-message-for-viewing-enrollment.patch (text/plain), 1.69 KB, created by Martin Renvoize (ashimema) on 2022-09-12 16:14:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-09-12 16:14:20 UTC

Size: 1.69 KB

patch

obsolete

>From 734f0a9bffe8b296e83f8397c7c7bbd5b9886789 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi>
>Date: Fri, 2 Sep 2022 18:51:25 +0000
>Subject: [PATCH] Bug 31516: Add error message for viewing enrollments for a
> non-existent club
>
>To test:
> 1) Go to non-existent club's enrollment page, e.g.
>    http://localhost:8081/cgi-bin/koha/clubs/club-enrollments.pl?id=1010101001000
> 2) Notice the not fully filled header text and empty table
> 3) Apply patch and revisit the page to see the proper error message given
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../intranet-tmpl/prog/en/modules/clubs/club-enrollments.tt  | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/club-enrollments.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/club-enrollments.tt
>index 4383291728..ab26a7bc26 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/club-enrollments.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/club-enrollments.tt
>@@ -36,7 +36,9 @@
>     <div class="row">
>         <div class="col-sm-10 col-sm-push-2">
>             <main>
>-
>+                [% IF !club %]
>+                <div class="dialog message">The club you requested does not exist.</div>
>+                [% ELSE %]
>                 <h1>Club enrollments for <em>[% club.name | html %]</em></h1>
> 
>                 <table id="enrollments-table">
>@@ -61,6 +63,7 @@
>                         [% END %]
>                     </tbody>
>                 </table>
>+                [% END %]
> 
>             </main>
>         </div> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 31516: 140178 | 140179 | 140326 | 140475