Bugzilla – Attachment 140591 Details for
Bug 30982
Use the REST API for background job list view
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30982: (QA follow-up) Double quoting and console.log
Bug-30982-QA-follow-up-Double-quoting-and-consolel.patch (text/plain), 3.96 KB, created by
Martin Renvoize (ashimema)
on 2022-09-13 14:57:04 UTC
(
hide
)
Description:
Bug 30982: (QA follow-up) Double quoting and console.log
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-09-13 14:57:04 UTC
Size:
3.96 KB
patch
obsolete
>From 9350738fb687ad50f24b3d6f3076198d41979613 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 28 Jun 2022 08:10:38 +0100 >Subject: [PATCH] Bug 30982: (QA follow-up) Double quoting and console.log > >This patch fixes the issues highlighted by the QA script; We use double >quotes for translatable strings in JS and remove an errant console.log >call. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../prog/en/modules/admin/background_jobs.tt | 31 +++++++++---------- > 1 file changed, 15 insertions(+), 16 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt >index f30990e160..3456fed233 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt >@@ -311,12 +311,12 @@ > }); > > const job_statuses = [ >- {'_id': 'new', '_str': _('New')}, >- {'_id': 'cancelled', '_str': _('Cancelled')}, >- {'_id': 'finished', '_str': _('Finished')}, >- {'_id': 'started', '_str': _('Started')}, >- {'_id': 'running', '_str': _('Running')}, >- {'_id': 'failed', '_str': _('Failed')}, >+ {'_id': 'new', '_str': _("New")}, >+ {'_id': 'cancelled', '_str': _("Cancelled")}, >+ {'_id': 'finished', '_str': _("Finished")}, >+ {'_id': 'started', '_str': _("Started")}, >+ {'_id': 'running', '_str': _("Running")}, >+ {'_id': 'failed', '_str': _("Failed")}, > ]; > function get_job_status (status) { > let status_lib = job_statuses.find( s => s._id == status ); >@@ -329,39 +329,39 @@ > const job_types = [ > { > '_id': 'batch_biblio_record_modification', >- '_str': _('Batch bibliographic record modification') >+ '_str': _("Batch bibliographic record modification") > }, > { > '_id': 'batch_biblio_record_deletion', >- '_str': _('Batch bibliographic record record deletion') >+ '_str': _("Batch bibliographic record record deletion") > }, > { > '_id': 'batch_authority_record_modification', >- '_str': _('Batch authority record modification') >+ '_str': _("Batch authority record modification") > }, > { > '_id': 'batch_authority_record_deletion', >- '_str': _('Batch authority record deletion') >+ '_str': _("Batch authority record deletion") > }, > { > '_id': 'batch_item_record_modification', >- '_str': _('Batch item record modification') >+ '_str': _("Batch item record modification") > }, > { > '_id': 'batch_item_record_deletion', >- '_str': _('Batch item record deletion') >+ '_str': _("Batch item record deletion") > }, > { > '_id': 'batch_hold_cancel', >- '_str': _('Batch hold cancellation') >+ '_str': _("Batch hold cancellation") > }, > { > '_id': 'update_elastic_index' >- , '_str': _('Update Elasticsearch index') >+ , '_str': _("Update Elasticsearch index") > }, > { > '_id': 'update_holds_queue_for_biblios', >- '_str': _('Holds queue update') >+ '_str': _("Holds queue update") > } > ]; > >@@ -381,7 +381,6 @@ > now.setHours(now.getHours() - 1); > return { ">": now.toISOString() }; > } else { >- console.log("not checked"); > return { "<": now.toISOString() }; > } > }, >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30982
:
136245
|
136246
|
136670
|
136671
|
136672
|
136707
|
136708
|
136715
|
138114
|
139636
|
139637
|
139638
|
139639
|
139640
|
139641
|
140488
|
140489
|
140490
|
140491
|
140492
|
140493
|
140494
|
140495
|
140496
|
140497
|
140498
|
140589
|
140590
|
140591
|
140592
|
140593
|
140594
|
140595
|
140596
|
140597
|
140598
|
140599
|
140789
|
140884
|
140885
|
140886
|
140887
|
140888
|
140889
|
140890
|
140891
|
140892
|
140893
|
140894
|
140895
|
140896
|
140897
|
142859