Attachment 140675 Details for Bug 31380 – Bug 31380: Add unit tests

[patch] Bug 31380: Add unit tests

Bug-31380-Add-unit-tests.patch (text/plain), 3.44 KB, created by Martin Renvoize (ashimema) on 2022-09-15 14:20:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-09-15 14:20:56 UTC

Size: 3.44 KB

patch

obsolete

>From be50b94f3ec4da4526caf942ae1243726d28642c Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Thu, 18 Aug 2022 06:57:42 +0000
>Subject: [PATCH] Bug 31380: Add unit tests
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/Koha/Auth.t | 92 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 92 insertions(+)
> create mode 100755 t/db_dependent/Koha/Auth.t
>
>diff --git a/t/db_dependent/Koha/Auth.t b/t/db_dependent/Koha/Auth.t
>new file mode 100755
>index 0000000000..b5f88a1a44
>--- /dev/null
>+++ b/t/db_dependent/Koha/Auth.t
>@@ -0,0 +1,92 @@
>+#!/usr/bin/perl
>+
>+use Modern::Perl;
>+use C4::Auth qw( get_session );
>+use Test::More tests => 5;
>+use t::lib::TestBuilder;
>+
>+use Koha::Database;
>+
>+use_ok('Koha::Auth');
>+
>+my $schema = Koha::Database->new->schema;
>+$schema->storage->txn_begin;
>+
>+subtest 'Successful authentication' => sub {
>+    plan tests => 2;
>+
>+    $ENV{REMOTE_ADDR} = '127.0.0.1';
>+    my $builder = t::lib::TestBuilder->new;
>+    my $borrower = $builder->build({ source => 'Borrower' });
>+    my $session = C4::Auth::get_session;
>+    $session->param( 'id',           $borrower->{userid} );
>+    $session->param( 'lasttime', time() );
>+    $session->param( 'ip', '127.0.0.1' );
>+    $session->flush;
>+    my $sessionID = $session->id;
>+
>+    my ($user,$user_session) = Koha::Auth->authenticate({
>+        sessionID => $sessionID,
>+    });
>+    is(ref $user, 'Koha::Patron', 'User found');
>+    is(ref $user_session, 'CGI::Session', 'User session found');
>+
>+    $session->delete;
>+};
>+
>+subtest 'Failed authentication' => sub {
>+    plan tests => 2;
>+
>+    $ENV{REMOTE_ADDR} = '127.0.0.1';
>+    my $session = C4::Auth::get_session;
>+    $session->flush;
>+    $session->param( 'ip', '127.0.0.1' );
>+    my $sessionID = $session->id;
>+
>+    my ($user,$user_session) = Koha::Auth->authenticate({
>+        sessionID => $sessionID,
>+    });
>+    is($user, undef, 'User not found');
>+    is($user_session, undef, 'User session not found');
>+
>+    $session->delete;
>+};
>+
>+subtest 'Superlibrarian authorization' => sub {
>+    plan tests => 1;
>+    my $builder = t::lib::TestBuilder->new;
>+    my $borrower = $builder->build({ source => 'Borrower', value => {flags => 1,} });
>+
>+    my $session = C4::Auth::get_session;
>+    $session->param( 'id',           $borrower->{userid} );
>+    $session->param( 'lasttime', time() );
>+    $session->param( 'ip', '127.0.0.1' );
>+    $session->flush;
>+
>+    my $flags = Koha::Auth->authorize({
>+        session => $session,
>+        flagsrequired => { circulate => 1 },
>+    });
>+    is($flags->{superlibrarian},1,'Got superlibrarian authorization');
>+};
>+
>+subtest 'Circulation staff authorization' => sub {
>+    plan tests => 2;
>+    my $builder = t::lib::TestBuilder->new;
>+    my $borrower = $builder->build({ source => 'Borrower', value => {flags => 2,} });
>+
>+    my $session = C4::Auth::get_session;
>+    $session->param( 'id',           $borrower->{userid} );
>+    $session->param( 'lasttime', time() );
>+    $session->param( 'ip', '127.0.0.1' );
>+    $session->flush;
>+
>+    my $flags = Koha::Auth->authorize({
>+        session => $session,
>+        flagsrequired => { circulate => 1 },
>+    });
>+    is($flags->{superlibrarian},0,'Did not get superlibrarian authorization');
>+    is($flags->{circulate},1,'Did get circulate authorization');
>+};
>+
>+$schema->storage->txn_rollback;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 31380: 139308 | 139309 | 139312 | 139313 | 139314 | 139315 | 139316 | 139317 | 139318 | 139319 | 139320 | 139321 | 139322 | 139323 | 139324 | 139325 | 139327 | 139328 | 139394 | 139395 | 139396 | 139818 | 139819 | 139820 | 140673 | 140674 | 140675 | 144968 | 144969 | 144970 | 158583 | 158584