Attachment 140681 Details for Bug 31569 – Bug 31569: Remove unecessary imports

[patch] Bug 31569: Remove unecessary imports

Bug-31569-Remove-unecessary-imports.patch (text/plain), 1.44 KB, created by ByWater Sandboxes on 2022-09-15 15:01:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2022-09-15 15:01:28 UTC

Size: 1.44 KB

patch

obsolete

>From 29f976349d09f62737676a5be29f1a77a82e8d45 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 15 Sep 2022 13:50:35 +0000
>Subject: [PATCH] Bug 31569: Remove unecessary imports
>
>By using objects a number of other routines are not needed:
>GetImportRecordMarc SetImportRecordStatus SetMatchedBiblionumber
>
>To test:
>Grep for routines above in addorderiso2709 and confirm they are not used
>
>Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
>---
> acqui/addorderiso2709.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl
>index a235ca162a..b65663d862 100755
>--- a/acqui/addorderiso2709.pl
>+++ b/acqui/addorderiso2709.pl
>@@ -30,7 +30,7 @@ use Encode;
> use C4::Context;
> use C4::Auth qw( get_template_and_user );
> use C4::Output qw( output_html_with_http_headers );
>-use C4::ImportBatch qw( GetImportRecordMarc GetImportRecordMatches SetImportRecordStatus SetMatchedBiblionumber SetImportBatchStatus GetImportBatch GetImportBatchRangeDesc GetNumberOfNonZ3950ImportBatches GetImportBatchOverlayAction GetImportBatchNoMatchAction GetImportBatchItemAction );
>+use C4::ImportBatch qw( GetImportRecordMatches SetImportBatchStatus GetImportBatch GetImportBatchRangeDesc GetNumberOfNonZ3950ImportBatches GetImportBatchOverlayAction GetImportBatchNoMatchAction GetImportBatchItemAction );
> use C4::Matcher;
> use C4::Search qw( FindDuplicate );
> use C4::Biblio qw(
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31569: 140659 | 140660 | 140661 | 140662 | 140663 | 140664 | 140665 | 140676 | 140677 | 140678 | 140679 | 140680 | 140681 | 140682 | 141504 | 141505 | 141506 | 141507 | 141508 | 141509 | 141510 | 141511 | 142031