Bugzilla – Attachment 140710 Details for
Bug 31575
Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31575 - Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed
Bug-31575---Missing-warning-for-holds-where-AllowH.patch (text/plain), 1.71 KB, created by
Kyle M Hall (khall)
on 2022-09-16 14:49:35 UTC
(
hide
)
Description:
Bug 31575 - Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2022-09-16 14:49:35 UTC
Size:
1.71 KB
patch
obsolete
>From 082294ab983cfe7e20d1966cdadd412a28e55db1 Mon Sep 17 00:00:00 2001 >From: Kyle Hall <kyle@bywatersolutions.com> >Date: Fri, 16 Sep 2022 10:47:48 -0400 >Subject: [PATCH] Bug 31575 - Missing warning for holds where > AllowHoldPolicyOverride can be used to force a hold to be placed > >If some holds are overridable, and AllowHoldPolicyOverride is enabled, Koha used to "flag" each holdable item to let librarians know the hold could not normally be placed. In 22.05 up to current master as of this writing, no warning is displayed. > >Test Plan: >1) Set one circ rule to allow 0 holds >2) For Library A, set "Hold pickup library match" to "item's hold group" >3) Enable AllowHoldPolicyOverride >4) Set ReservesControlBranch to "item's home branch" >5) Create a record with an item for Library A, one for Library B, and one for Library C > This should create a scenario where A's item cannot be held, and B and C's items must be overridden >6) Note you get the "Cannot place hold" but can place those holds anyway without a "warning" sign >7) Apply this patch >8) Restart all the things! >9) Reload the page, you should now see the warning icons! >--- > reserve/request.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 5fcb7ad0b2..b518504e7f 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -535,7 +535,7 @@ if ( ( $findborrower && $borrowernumber_hold || $findclub && $club_hold ) > > if ( @pickup_locations ) { > $num_items_available++; >- $item->{available} = 1; >+ $item->{override} = 1; > > my $default_pickup_location; > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31575
:
140710
|
140737
|
141489