Bugzilla – Attachment 140740 Details for
Bug 31465
Link system preference tabs to correct manual pages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31465: (follow-up) Link to preference tabs directly
Bug-31465-follow-up-Link-to-preference-tabs-direct.patch (text/plain), 3.15 KB, created by
David Nind
on 2022-09-18 21:13:18 UTC
(
hide
)
Description:
Bug 31465: (follow-up) Link to preference tabs directly
Filename:
MIME Type:
Creator:
David Nind
Created:
2022-09-18 21:13:18 UTC
Size:
3.15 KB
patch
obsolete
>From 573a931a1b949918af860d56f04c04ce56f2879c Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 16 Sep 2022 12:33:31 +0100 >Subject: [PATCH] Bug 31465: (follow-up) Link to preference tabs directly > >This patch enhances the mapping system for the help button to allow for >each tab of preferences to link directly to the relevent section of the >manual. > >Signed-off-by: David Nind <david@davidnind.com> >--- > Koha/Manual.pm | 29 ++++++++++++++++++++++++++++- > 1 file changed, 28 insertions(+), 1 deletion(-) > >diff --git a/Koha/Manual.pm b/Koha/Manual.pm >index f1d012de14..46641f8127 100644 >--- a/Koha/Manual.pm >+++ b/Koha/Manual.pm >@@ -90,6 +90,23 @@ our $mapping = { > 'admin/oai_sets' => '/administration.html#oai-sets-configuration', > 'admin/patron-attr-types' => '/administration.html#patron-attribute-types', > 'admin/preferences' => '/globalpreferences.html', >+ 'admin/preferences#accounting' => '/accountspreferences.html', >+ 'admin/preferences#acquisitions' => '/acquisitionspreferences.html', >+ 'admin/preferences#admin' => '/administrationpreferences.html', >+ 'admin/preferences#authorities' => '/authoritiespreferences.html', >+ 'admin/preferences#cataloguing' => '/catalogingpreferences.html', >+ 'admin/preferences#circulation' => '/circulationpreferences.html', >+ 'admin/preferences#enhanced_content' => '/enhancedcontentpreferences.html', >+ 'admin/preferences#i18n_l10n' => '/i18npreferences.html', >+ 'admin/preferences#logs' => '/logspreferences.html', >+ 'admin/preferences#opac' => '/opacpreferences.html', >+ 'admin/preferences#patrons' => '/patronspreferences.html', >+ 'admin/preferences#searching' => '/searchingpreferences.html', >+ 'admin/preferences#serials' => '/serialspreferences.html', >+ 'admin/preferences#staff_interface' => '/staffclientpreferences.html', >+ 'admin/preferences#staff_interface' => '/staffclientpreferences.html', >+ 'admin/preferences#tools' => '/toolspreferences.html', >+ 'admin/preferences#web_services' => '/webservicespreferences.html', > 'admin/smart-rules' => '/administration.html#circulation-and-fine-rules', > 'admin/sms_providers' => '/administration.html#sms-cellular-providers', > 'admin/systempreferences' => '/localusepreferences.html', >@@ -242,8 +259,18 @@ sub get_url { > } > $file =~ s/[^a-zA-Z0-9_\-\/]*//g; > >+ my $view; >+ if ($url =~ /(?:\?|\&)tab=(?<value>[\w+,.-]*)/) { >+ $view = $file . '#' . $+{value}; >+ } >+ > my $base_url = _get_base_url( $preferred_language ); >- return $base_url . ( exists $mapping->{$file} ? $mapping->{$file} : $mapping->{mainpage} ); >+ return $base_url >+ . ( >+ exists $mapping->{$view} ? $mapping->{$view} >+ : exists $mapping->{$file} ? $mapping->{$file} >+ : $mapping->{mainpage} >+ ); > } > > 1; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31465
:
140702
|
140704
|
140739
|
140740
|
140804
|
140805