Bugzilla – Attachment 140806 Details for
Bug 23063
Item table in cataloguing doesn't respect CurrencyFormat
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23063: Use Price formatting on amounts in item table in cataloguing
Bug-23063-Use-Price-formatting-on-amounts-in-item-.patch (text/plain), 2.22 KB, created by
Katrin Fischer
on 2022-09-20 20:56:19 UTC
(
hide
)
Description:
Bug 23063: Use Price formatting on amounts in item table in cataloguing
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-09-20 20:56:19 UTC
Size:
2.22 KB
patch
obsolete
>From 007f09753e885d5a5ffdb08ba4d829da41e5d36e Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Tue, 20 Sep 2022 20:49:22 +0000 >Subject: [PATCH] Bug 23063: Use Price formatting on amounts in item table in > cataloguing > >Koha can use CurrencyFormat for displaying price amounts and should do >so consistently everywhere. Without this patch price and replacement cost >will always display as xx.xx independent of CurrencyFormat setting in >the table above the edit items form. This patch fixes the table display. > >To test: >* Apply patch >* Search or create a record with multiple items >* Fill in some price and replacement costs >* Try different settings of the CurrencyFormat system preference >* The display in the item table above the edit/add form should display > according to the system preference >* Verify sorting works >--- > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >index 31eaf8e3bd..61a442f6de 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >@@ -3,6 +3,7 @@ > [% USE Koha %] > [% USE Branches %] > [% USE KohaDates %] >+[% USE Price %] > [% USE TablesSettings %] > [% INCLUDE 'doc-head-open.inc' %] > <title>Items › [% biblio.title | html %] [% IF ( biblio.author ) %] by [% biblio.author | html %][% END %] (Record #[% biblio.biblionumber | html %]) › Cataloging › Koha</title> >@@ -126,6 +127,8 @@ > [% SET attribute = header.attribute %] > [% IF header.attribute AND date_fields.grep('^' _ attribute _ '$').size %] > <td data-order="[% item.$attribute | html %]">[% item.$attribute | $KohaDates %]</td> >+ [% ELSIF ( item.$attribute && ( attribute == 'price' || attribute == 'replacementprice' ) ) %] >+ <td data-order="[% item.$attribute | html %]">[% item.$attribute | $Price %]</td> > [% ELSE %] > <td>[% item.$attribute | html %]</td> > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23063
:
140806
|
140812
|
141259