Attachment 140818 Details for Bug 31593 – Bug 31593: Remove Test::DBIx::Class from Context.t

[patch] Bug 31593: Remove Test::DBIx::Class from Context.t

Bug-31593-Remove-TestDBIxClass-from-Contextt.patch (text/plain), 1.18 KB, created by Marcel de Rooy on 2022-09-21 13:56:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2022-09-21 13:56:39 UTC

Size: 1.18 KB

patch

obsolete

>From fd693fab0f80138baf1a122d689bb493f3010b54 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 21 Sep 2022 13:54:54 +0000
>Subject: [PATCH] Bug 31593: Remove Test::DBIx::Class from Context.t
>Content-Type: text/plain; charset=utf-8
>
>No need to keep it.
>Fixing a test description too.
>
>Test plan:
>Run t/db_dependent/Context.t
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/Context.t | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Context.t b/t/db_dependent/Context.t
>index 77a8924822..9b954efb24 100755
>--- a/t/db_dependent/Context.t
>+++ b/t/db_dependent/Context.t
>@@ -52,7 +52,8 @@ $dbh->rollback;
> ok($koha = C4::Context->new,  'C4::Context->new');
> my @keys = keys %$koha;
> my $width = 0;
>-if (ok(@keys)) { 
>+ok( @keys, 'Expecting entries in context hash' );
>+if( @keys ) {
>     $width = (sort {$a <=> $b} map {length} @keys)[-1];
> }
> foreach (sort @keys) {
>@@ -64,7 +65,6 @@ foreach (sort @keys) {
> ok($config = $koha->{config}, 'Getting $koha->{config} ');
> 
> # Testing syspref caching
>-use Test::DBIx::Class;
> 
> my $schema = Koha::Database->new()->schema();
> $schema->storage->debug(1);
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31593: 140818 | 141204