Bugzilla – Attachment 140832 Details for
Bug 29196
Follow-up to Bug 27068 - Remove unnecessary check
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29196: Follow-up to Bug 27068 - Remove unnecessary check
Bug-29196-Follow-up-to-Bug-27068---Remove-unnecess.patch (text/plain), 2.37 KB, created by
Nick Clemens (kidclamp)
on 2022-09-21 19:50:53 UTC
(
hide
)
Description:
Bug 29196: Follow-up to Bug 27068 - Remove unnecessary check
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-09-21 19:50:53 UTC
Size:
2.37 KB
patch
obsolete
>From 264e0cef54b3653043925db48bab02a22d596236 Mon Sep 17 00:00:00 2001 >From: Kyle Hall <kyle@bywatersolutions.com> >Date: Wed, 13 Oct 2021 12:20:33 -0400 >Subject: [PATCH] Bug 29196: Follow-up to Bug 27068 - Remove unnecessary check > >The introduction of _checkHoldPolicy has made this check superfluous. >Test plan stolen/updated from 27068 > >To test: > 1) In library groups add a root group and check it as hold group. > 2) Add two libraries to the group > 3) In circulation and fines rules, in 'Default checkout, hold and return > policy', in Hold pickup library match change the value to 'From patron's hold group' > 4) Place a hold from a patron whose home library is from the group > 4.5) perl misc/cronjobs/holds/build_holdsqueue.pl > 5) Go to /cgi-bin/koha/circ/view_holdsqueue.pl > 6) Select the holding branch of the item with a hold > 7) observe no results > 8) Apply Patch > 9) Repeat 5-6 >10) The item should come up on the holds queue results >11) Place a hold on an item where 1 record has 2 copies, 1 in the hold group, 1 not. >12) Run the HoldQueue for the library not in the group and make sure the hold isn't showing. >13) Turn on transportation cost matrix and set costs for the libraries within the group. >14) Place a hold for a patron where multiple copies are on the bib. >15) Check both branch's hold queue for the item, it should only show on the lower cost branch's list if both copies are available. > >Signed-off-by: David Nind <david@davidnind.com> >--- > C4/HoldsQueue.pm | 4 ---- > 1 file changed, 4 deletions(-) > >diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm >index 8173efaae8..7d0d4abc25 100644 >--- a/C4/HoldsQueue.pm >+++ b/C4/HoldsQueue.pm >@@ -623,10 +623,6 @@ sub MapItemsToHoldRequests { > next unless _checkHoldPolicy($item, $request); > next unless $items_by_itemnumber{ $item->{itemnumber} }->{_object}->can_be_transferred( { to => $libraries->{ $request->{branchcode} } } ); > >- # Don't fill item level holds that contravene the hold pickup policy at this time >- next unless $item->{hold_fulfillment_policy} eq 'any' >- || $request->{branchcode} eq $item->{ $item->{hold_fulfillment_policy} }; >- > # If hold itemtype is set, item's itemtype must match > next unless ( !$request->{itemtype} > || $item->{itype} eq $request->{itemtype} ); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29196
:
125963
|
126226
|
126788
|
140832
|
141131
|
141155