Bugzilla – Attachment 140883 Details for
Bug 31615
Allow checkin of items bundles without verifying their contents
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31615: Allow checkin of items bundles without verifying their contents
Bug-31615-Allow-checkin-of-items-bundles-without-v.patch (text/plain), 2.65 KB, created by
Julian Maurice
on 2022-09-23 08:19:45 UTC
(
hide
)
Description:
Bug 31615: Allow checkin of items bundles without verifying their contents
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2022-09-23 08:19:45 UTC
Size:
2.65 KB
patch
obsolete
>From 509bce988511046d0c7c2cb979b7c907c8420249 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Fri, 23 Sep 2022 10:12:22 +0200 >Subject: [PATCH] Bug 31615: Allow checkin of items bundles without verifying > their contents > >This patch adds a button in the "bundle verification" modal to skip >this step and do the checkin anyway. > >Test plan: >1. Create an items bundle (see bug 28854 comment 458) >2. Check out this bundle, then return it. The "bundle verification" > modal should appear >3. Leave the textarea empty and click on "Confirm checkin without > verifying bundle contents" >4. Confirm that the bundle was correctly returned, and no items were > marked as lost >--- > circ/returns.pl | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > >diff --git a/circ/returns.pl b/circ/returns.pl >index 4ba8812888..366fd1e2fb 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -415,7 +415,7 @@ if ($barcode) { > } > > # Mark missing bundle items as lost and report unexpected items >- if ( $item && $item->is_bundle && $query->param('confirm_items_bundle_return') ) { >+ if ( $item && $item->is_bundle && $query->param('confirm_items_bundle_return') && !$query->param('do_not_verify_items_bundle_contents') ) { > my $BundleLostValue = C4::Context->preference('BundleLostValue'); > my $barcodes = $query->param('verify-items-bundle-contents-barcodes'); > my @barcodes = map { s/^\s+|\s+$//gr } ( split /\n/, $barcodes ); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index be91ab7be7..ea052bc7dd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -497,6 +497,7 @@ > [% END %] > [% IF item.onloan %] > <button type="submit" class="btn btn-default"><i class="fa fa-check"></i> Confirm checkin and mark missing items as lost</button> >+ <button type="submit" class="btn btn-default" name="do_not_verify_items_bundle_contents" value="1"><i class="fa fa-check"></i> Confirm checkin without verifying bundle contents</button> > [% ELSE %] > <button type="submit" class="btn btn-default"><i class="fa fa-check"></i> Confirm inventory check and mark items as lost</button> > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31615
:
140883
|
146019
|
148069