Attachment 140900 Details for Bug 25375 – Bug 23735: Spelling fixes

[patch] Bug 23735: Spelling fixes

Bug-23735-Spelling-fixes.patch (text/plain), 1.76 KB, created by Tomás Cohen Arazi (tcohen) on 2022-09-23 12:06:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-09-23 12:06:29 UTC

Size: 1.76 KB

patch

obsolete

>From 972a596e6946762351911c083ba56fa5c1b22694 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 23 Sep 2022 09:06:11 -0300
>Subject: [PATCH] Bug 23735: Spelling fixes
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>https://bugs.koha-community.org/show_bug.cgi?id=25375
>---
> Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>index 9679babc953..a6ebecfe106 100644
>--- a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>+++ b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>@@ -791,7 +791,7 @@ will have to wait for a real query parser.
> 
> sub _convert_index_strings_freeform {
>     my ( $self, $search ) = @_;
>-    # @TODO: Currenty will alter also fields contained within quotes:
>+    # @TODO: Currently will alter also fields contained within quotes:
>     # `searching for "stuff cn:123"` for example will become
>     # `searching for "stuff local-number:123"
>     #
>@@ -1028,9 +1028,9 @@ sub _query_regex_escape_process {
>             # Will escape unescaped slashes (/) while preserving
>             # unescaped slashes within quotes
>             # @TODO: assumes quotes are always balanced and will
>-            # not handle escaped qoutes properly, should perhaps be
>+            # not handle escaped quotes properly, should perhaps be
>             # replaced with a more general parser solution
>-            # so that this function is ever only provided with unqouted
>+            # so that this function is ever only provided with unquoted
>             # query parts
>             $query =~ s@(?:(?<!\\)((?:[\\]{2})*)(?=/))(?![^"]*"(?:[^"]*"[^"]*")*[^"]*$)@\\$1@g;
>         }
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 25375: 104356 | 109647 | 109659 | 109660 | 109951 | 109952 | 109953 | 109954 | 131310 | 131311 | 131312 | 131313 | 132327 | 132328 | 132329 | 132330 | 138800 | 138802 | 138803 | 140053 | 140054 | 140055 | 140056 | 140057 | 140572 | 140899 | 140900 | 140979