Bugzilla – Attachment 140957 Details for
Bug 31419
Add accesskeys to recall modal
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31419: Add accesskeys for modals
Bug-31419-Add-accesskeys-for-modals.patch (text/plain), 5.42 KB, created by
Kyle M Hall (khall)
on 2022-09-23 16:27:54 UTC
(
hide
)
Description:
Bug 31419: Add accesskeys for modals
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2022-09-23 16:27:54 UTC
Size:
5.42 KB
patch
obsolete
>From ffd69e4633d1f9494e59cd9533e1829195c2529a Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 19 Aug 2022 10:04:56 +0000 >Subject: [PATCH] Bug 31419: Add accesskeys for modals > >This patch simply adds accesskey elements to the buttons, and changes an icon to be >consistent with bug 26626 > >For tips on how to access the accesskeys: >https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey > >To test: >1 - Generate a recall >2 - Fill it/check in >3 - Note modal now has hints "Confirm (Y)" >4 - Test with Y,P,I keys (may need to recreate recalls) >5 - Confirm the recall and test waiting recall modal too > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../prog/en/modules/circ/returns.tt | 28 +++++++++---------- > 1 file changed, 14 insertions(+), 14 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index be91ab7be7..023a1af80a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -944,18 +944,18 @@ > > <div class="modal-footer"> > [% IF ( transfertodo ) %] >- <button type="submit" class="btn btn-default approve"> >- <i class="fa fa-check"></i> Confirm recall and transfer >+ <button type="submit" class="btn btn-default approve" accesskey="Y"> >+ <i class="fa fa-check"></i> Confirm recall and transfer (Y) > </button> >- <button type="button" class="btn btn-default print-recall"> >- <i class="fa fa-print"></i> Print slip, transfer, and confirm >+ <button type="button" class="btn btn-default print-recall" accesskey="P"> >+ <i class="fa fa-print"></i> Print slip, transfer, and confirm (P) > </button> > [% ELSE %] >- <button type="submit" class="btn btn-default approve"> >- <i class="fa fa-check"></i> Confirm recall >+ <button type="submit" class="btn btn-default approve" accesskey="Y"> >+ <i class="fa fa-check"></i> Confirm recall (Y) > </button> >- <button type="button" class="btn btn-default print-recall"> >- <i class="fa fa-print"></i> Print slip and confirm >+ <button type="button" class="btn btn-default print-recall" accesskey="P"> >+ <i class="fa fa-print"></i> Print slip and confirm (P) > </button> > [% END %] > >@@ -1044,15 +1044,15 @@ > </div> > > <div class="modal-footer"> >- <button type="submit" class="btn btn-default approve"> >- <i class="fa fa-check"></i> Confirm recall >+ <button type="submit" class="btn btn-default approve" accesskey="Y"> >+ <i class="fa fa-check"></i> Confirm recall (Y) > </button> >- <button type="button" class="btn btn-default print-recall"> >- <i class="fa fa-print"></i> Print slip and confirm >+ <button type="button" class="btn btn-default print-recall" accesskey="P"> >+ <i class="fa fa-print"></i> Print slip and confirm (P) > </button> > >- <button data-dismiss="modal" aria-hidden="true" type="submit" class="btn btn-default deny"> >- <i class="fa fa-times"></i> Ignore >+ <button data-dismiss="modal" aria-hidden="true" type="submit" class="btn btn-default deny" accesskey="I"> >+ <i class="fa fa-remove"></i> Ignore (I) > </button> > </div> <!-- /.modal-footer --> > </form> <!-- /.confirm --> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31419
:
139473
|
139562
| 140957