Bugzilla – Attachment 140961 Details for
Bug 31496
SCO slip uses data of patron's home library instead of the SCO staff users's library
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31496: Fix branch in printslip.pl to logged in staff user's library
Bug-31496-Fix-branch-in-printslippl-to-logged-in-s.patch (text/plain), 1.70 KB, created by
Kyle M Hall (khall)
on 2022-09-23 18:39:17 UTC
(
hide
)
Description:
Bug 31496: Fix branch in printslip.pl to logged in staff user's library
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2022-09-23 18:39:17 UTC
Size:
1.70 KB
patch
obsolete
>From 79f08bf7718aaaa84fccc5c81b9ed702c2d563c1 Mon Sep 17 00:00:00 2001 >From: lmstrand <lmstrand@gmail.com> >Date: Wed, 31 Aug 2022 15:39:42 +0300 >Subject: [PATCH] Bug 31496: Fix branch in printslip.pl to logged in staff > user's library > >When you print a receipt slip in SCO, the library/branch you are at >in should be fetched from the logged in staff member's data (staff login >done before entering SCO view) instead of the patron's own who has signed >in to the SCO. Printing a slip shows patron's own home branch in the slip >as the branch they're in. This causes confusion with patrons who want to >print receipts/slips. > >Test plan: >1) Make sure the staff user's library (used to login into SCO patron > view) is not the same as the patron's who is logging into SCO >2) Print a slip in SCO and notice patron's home library printed on the slip >3) Apply patch >4) Print a slip in SCO and notice the library is now the staff user's library > used to sign in to SCO patron view. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > opac/sco/printslip.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/opac/sco/printslip.pl b/opac/sco/printslip.pl >index ae0f58314a..adac4dff2f 100755 >--- a/opac/sco/printslip.pl >+++ b/opac/sco/printslip.pl >@@ -80,7 +80,7 @@ my $print = $input->param('print'); > my $error = $input->param('error'); > > my ($slip, $is_html); >-if (my $letter = IssueSlip ($patron->branchcode, $patron->borrowernumber, $print eq "qslip")) { >+if (my $letter = IssueSlip (Koha::Patrons->find( $loggedinuser )->branchcode, $patron->borrowernumber, $print eq "qslip")) { > $slip = $letter->{content}; > $is_html = $letter->{is_html}; > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31496
:
140003
|
140031
|
140267
| 140961