Attachment 140988 Details for Bug 29440 – Bug 29440: Rename $modify_biblio_marc_options to $mod_bilbio_options

[patch] Bug 29440: Rename $modify_biblio_marc_options to $mod_bilbio_options

Bug-29440-Rename-modifybibliomarcoptions-to-modbil.patch (text/plain), 2.81 KB, created by David Gustafsson on 2022-09-26 14:56:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Gustafsson

Created: 2022-09-26 14:56:37 UTC

Size: 2.81 KB

patch

obsolete

>From c2992c7881231167ccb182339bf1919ca3d6aa97 Mon Sep 17 00:00:00 2001
>From: David Gustafsson <david.gustafsson@ub.gu.se>
>Date: Mon, 26 Sep 2022 16:46:30 +0200
>Subject: [PATCH] Bug 29440: Rename $modify_biblio_marc_options to
> $mod_bilbio_options
>
>This variable actually contains ModBibio options and
>ModifyBiblioMarc accepts a subset of these
>---
> misc/migration_tools/bulkmarcimport.pl | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl
>index 8eb0a7515a..aaa61cd621 100755
>--- a/misc/migration_tools/bulkmarcimport.pl
>+++ b/misc/migration_tools/bulkmarcimport.pl
>@@ -124,7 +124,7 @@ if ($all) {
> }
> 
> my $using_elastic_search = (C4::Context->preference('SearchEngine') eq 'Elasticsearch');
>-my $modify_biblio_marc_options = {
>+my $mod_biblio_options = {
>     disable_autolink => $using_elastic_search,
>     defer_search_engine_indexing => $using_elastic_search,
>     overlay_context => { source => 'bulkmarcimport' }
>@@ -520,7 +520,7 @@ RECORD: foreach my $record (@{$marc_records}) {
>                 };
>                 if ($update) {
>                     my $success;
>-                    eval { $success = ModBiblio($record, $matched_record_id, GetFrameworkCode($matched_record_id), $modify_biblio_marc_options) };
>+                    eval { $success = ModBiblio($record, $matched_record_id, GetFrameworkCode($matched_record_id), $mod_biblio_options) };
>                     if ($@) {
>                         warn "ERROR: Update biblio $matched_record_id failed: $@\n";
>                         printlog( { id => $matched_record_id, op => "update", status => "ERROR" } ) if ($logfile);
>@@ -570,7 +570,7 @@ RECORD: foreach my $record (@{$marc_records}) {
>                 C4::Biblio::_strip_item_fields($clone_record, $framework);
>                 # This sets the marc fields if there was an error, and also calls
>                 # defer_marc_save.
>-                ModBiblioMarc($clone_record, $record_id, $modify_biblio_marc_options);
>+                ModBiblioMarc($clone_record, $record_id, $mod_biblio_options);
>                 if ($error_adding) {
>                     warn "ERROR: Adding items to bib $record_id failed: $error_adding";
>                     printlog({ id => $record_id, op => "insert items", status => "ERROR"}) if ($logfile);
>@@ -621,7 +621,7 @@ RECORD: foreach my $record (@{$marc_records}) {
> 
>                         # @FIXME: Why do we save here without stripping items? Besides,
>                         # save with stripped items has already been performed
>-                        ModBiblioMarc($record, $record_id, $modify_biblio_marc_options);
>+                        ModBiblioMarc($record, $record_id, $mod_biblio_options);
>                         next RECORD;
>                     }
>                     else {
>-- 
>2.35.1

Actions: View | Diff | Splinter Review

Attachments on bug 29440: 127479 | 127480 | 127481 | 127485 | 127486 | 127508 | 127509 | 127651 | 127652 | 127791 | 127792 | 127795 | 127796 | 127959 | 127960 | 127961 | 127963 | 128086 | 128087 | 128362 | 128890 | 128891 | 131176 | 131177 | 131180 | 131181 | 132942 | 140822 | 140823 | 140903 | 140904 | 140905 | 140906 | 140924 | 140925 | 140926 | 140927 | 140928 | 140987 | 140988 | 140989 | 143375 | 151293 | 151294 | 151295 | 151296 | 151297 | 151298 | 151299 | 151300 | 151301 | 157798 | 160148 | 160149 | 160150 | 160151 | 160152 | 160153 | 160154 | 160155 | 160156 | 160157 | 160477 | 160478 | 160479 | 160480 | 160481 | 160482 | 160483 | 160484 | 160485 | 160486 | 160487