Bugzilla – Attachment 141189 Details for
Bug 31633
Add home and holding data attributes to quick spine label print to help customizing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31633: Add holding and home data attributes to spinelabel-print.tt
Bug-31633-Add-holding-and-home-data-attributes-to-.patch (text/plain), 2.25 KB, created by
Katrin Fischer
on 2022-10-01 20:32:09 UTC
(
hide
)
Description:
Bug 31633: Add holding and home data attributes to spinelabel-print.tt
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-10-01 20:32:09 UTC
Size:
2.25 KB
patch
obsolete
>From ede6feceb09d9b208cca6b8de32a957bce5294b4 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 27 Sep 2022 16:44:24 +0000 >Subject: [PATCH] Bug 31633: Add holding and home data attributes to > spinelabel-print.tt > >To test: > >1. Apply patch >2. Have some items with call numbers and different holding/home branches. >3. Generate some quick spine labels and use your browsers dev tools to inscept the #spinelabel element. It should have 2 new data-attributes, data-homebranch and data-holdingbranch >4. You can then apply this CSS via IntraNnetUserCSS to make sure you can select these properly now: > > background: red; >} > >Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt | 2 +- > labels/spinelabel-print.pl | 4 ++++ > 2 files changed, 5 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt >index 6a48276f57..b81f77281d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt >@@ -22,7 +22,7 @@ > </div> > [% ELSE %] > <body id="labels_spinelabel-print" class="tools labels"> >- <div id="spinelabel" class="[% Branches.GetLoggedInBranchcode | html %]"> >+ <div id="spinelabel" class="[% Branches.GetLoggedInBranchcode | html %]" data-homebranch="[% itemhomebranch | html %]" data-holdingbranch="[% itemholdingbranch | html %]"> > [% content | $raw %] > </div> > <div id="print_button" class="noprint"> >diff --git a/labels/spinelabel-print.pl b/labels/spinelabel-print.pl >index 76a6fc5e36..265498c208 100755 >--- a/labels/spinelabel-print.pl >+++ b/labels/spinelabel-print.pl >@@ -82,6 +82,10 @@ while ( my ( $key, $value ) = each(%$data) ) { > > $body = $scheme; > >+$template->param( >+ 'itemhomebranch' => $item->{homebranch}, >+ 'itemholdingbranch' => $item->{holdingbranch} >+); > $template->param( autoprint => C4::Context->preference("SpineLabelAutoPrint") ); > $template->param( content => $body ); > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31633
:
141035
|
141036
|
141037
|
141188
|
141189
|
141190
|
141191
|
141283