Bugzilla – Attachment 141262 Details for
Bug 31594
Report results count of shown can be incorrect on last page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31594: Use count of results for displaying number shown
Bug-31594-Use-count-of-results-for-displaying-numb.patch (text/plain), 1.58 KB, created by
Tomás Cohen Arazi (tcohen)
on 2022-10-03 13:07:17 UTC
(
hide
)
Description:
Bug 31594: Use count of results for displaying number shown
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-10-03 13:07:17 UTC
Size:
1.58 KB
patch
obsolete
>From 926568a4e25628b2138aafaf62c9f4c3b8d4a8c2 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 21 Sep 2022 14:14:32 +0000 >Subject: [PATCH] Bug 31594: Use count of results for displaying number shown > >To test: >1 - Create a report with a number of results that is not a multiple of 20 > SELECT barcode FROM items >2 - Run the report >3 - Go to the final page >4 - Note report says 20 shown, but there are less >5 - Apply patch >6 - Reload and confirm correct number of shown is shown :-) > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > .../prog/en/modules/reports/guided_reports_start.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index fbf077c7c7..c629d73fcf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -913,7 +913,7 @@ > <span class="label">Total number of results:</span> > [% unlimited_total | html %] > [% IF unlimited_total >= limit %] >- ([% limit | html %] shown) >+ ([% results.size | html %] shown) > [% END %] > </p> > [% END %] >-- >2.37.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31594
:
140821
|
140827
|
141203
| 141262