Attachment 141280 Details for Bug 20457 – Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices

[patch] Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices

Bug-20457-Overdue-and-pre-overdue-cronjobs-not-ski.patch (text/plain), 3.22 KB, created by Katrin Fischer on 2022-10-03 16:34:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2022-10-03 16:34:31 UTC

Size: 3.22 KB

patch

obsolete

>From 2683ffa575b0dd96dedd5cc517b2f3dac5609872 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 25 Mar 2019 14:03:16 -0400
>Subject: [PATCH] Bug 20457: Overdue and pre-overdue cronjobs not skipping
> phone notices
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>The overdue and pre-overdue cron scripts are not skipping the generation of phone notices. This causes many phone notices to be created that will always be left at 'pending' as the Talking Tech outbound script creates its own phone notices and puts them in the message queue.
>
>Test Plan:
>1) Enable Talking Tech
>2) Enable predue and overdue notice phone transports for a patron
>3) Generate overdues and predues, notice phone notices are generated
>4) Apply the patch
>5) Repeat steps 2-3
>6) Note phone notices are not generated
>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@iki.fi>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> misc/cronjobs/advance_notices.pl | 3 +++
> misc/cronjobs/overdue_notices.pl | 1 +
> 2 files changed, 4 insertions(+)
>
>diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl
>index 9ec07659aa..725fc13482 100755
>--- a/misc/cronjobs/advance_notices.pl
>+++ b/misc/cronjobs/advance_notices.pl
>@@ -298,6 +298,7 @@ UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) {
> 
>             ## Get branch info for borrowers home library.
>             foreach my $transport ( keys %{$borrower_preferences->{'transports'}} ) {
>+                next if $transport eq 'itiva';
>                 my $letter = parse_letter( { letter_code    => $letter_type,
>                                       borrowernumber => $upcoming->{'borrowernumber'},
>                                       branchcode     => $branchcode,
>@@ -345,6 +346,7 @@ UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) {
> 
>             ## Get branch info for borrowers home library.
>             foreach my $transport ( keys %{$borrower_preferences->{'transports'}} ) {
>+                next if $transport eq 'itiva';
>                 my $letter = parse_letter( { letter_code    => $letter_type,
>                                       borrowernumber => $upcoming->{'borrowernumber'},
>                                       branchcode     => $branchcode,
>@@ -595,6 +597,7 @@ sub send_digests {
>         }
> 
>         foreach my $transport ( keys %{ $borrower_preferences->{'transports'} } ) {
>+            next if $transport eq 'itiva';
>             my $letter = parse_letter(
>                 {
>                     letter_code    => $params->{letter_code},
>diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl
>index 9c13fd279a..642c83fffa 100755
>--- a/misc/cronjobs/overdue_notices.pl
>+++ b/misc/cronjobs/overdue_notices.pl
>@@ -707,6 +707,7 @@ END_SQL
> 
>                 my $print_sent = 0; # A print notice is not yet sent for this patron
>                 for my $mtt ( @message_transport_types ) {
>+                    next if $mtt eq 'itiva';
>                     my $effective_mtt = $mtt;
>                     if ( ($mtt eq 'email' and not scalar @emails_to_use) or ($mtt eq 'sms' and not $data->{smsalertnumber}) ) {
>                         # email or sms is requested but not exist, do a print.
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 20457: 73141 | 86990 | 115311 | 140213 | 141280