Bugzilla – Attachment 141302 Details for
Bug 31503
Allow several consent types on the consents tab of OPAC account page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31503: (follow-up) Check return of GetByCode
Bug-31503-follow-up-Check-return-of-GetByCode.patch (text/plain), 2.87 KB, created by
Marcel de Rooy
on 2022-10-04 11:50:13 UTC
(
hide
)
Description:
Bug 31503: (follow-up) Check return of GetByCode
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2022-10-04 11:50:13 UTC
Size:
2.87 KB
patch
obsolete
>From b543da7db7819fb435f835f4e4a2d3c42364df70 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 4 Oct 2022 11:43:35 +0000 >Subject: [PATCH] Bug 31503: (follow-up) Check return of GetByCode >Content-Type: text/plain; charset=utf-8 > >AV.GetByCode returns code when there is no description. So we should >check the return. > >This patch also makes the use of the Do you agree-question a bit more >consistent. No need to include it in the description. > >Test plan: >Check the OPAC consents page when you have an AV description for a >consent type and when you do not. For GDPR you should see the original >GDPR text when there is no description. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > .../opac-tmpl/bootstrap/en/modules/opac-patron-consent.tt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-patron-consent.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-patron-consent.tt >index eef78ecead..c74452649c 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-patron-consent.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-patron-consent.tt >@@ -49,14 +49,15 @@ > <fieldset> > <ul><li> > [% description = AuthorisedValues.GetByCode( 'PATRON_CONSENT', consent.type, 1 ) # TODO additional_contents.content %] >- [% IF description %] >+ [% IF description && description != consent.type # TODO Should GetByCode return code? %] > [% description | $raw %] >+ <p>Do you agree?</p> > [% ELSIF consent.type == 'GDPR_PROCESSING' # Backward compatbility ;) %] > <p>Please read the <a target="_blank" href="[% Koha.Preference('PrivacyPolicyURL') | url %]">privacy policy</a>.</p> > <p>In order to keep you logged in, we need your consent to process personal data as specified in the EU General Data Protection Regulation of May 25, 2018. If you would not agree, we will need to <strong>remove</strong> your account within a reasonable time.</p> > <p>Do you agree with our processing of your personal data as outlined in the policy?</p> > [% ELSE # Fallback only %] >- <p>Description for [% consent.type | html %]. Do you agree?</p> >+ <p>Description for [% consent.type | html %].</p><p>Do you agree?</p> > [% END %] > <p> > <input type="radio" name="check_[% consent.type | html %]" value="1"> Yes<br> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31503
:
140047
|
140048
|
140049
|
140050
|
140080
|
140081
|
140082
|
140083
|
140084
|
140085
|
140087
|
140088
|
140089
|
140090
|
140666
|
140667
|
140668
|
140669
|
140670
|
140671
|
140672
|
141216
|
141217
|
141218
|
141219
|
141220
|
141221
|
141222
|
141263
|
141264
|
141265
|
141266
|
141267
|
141268
|
141269
|
141302
|
141570
|
155000
|
155001
|
155002
|
155003
|
155177
|
155178
|
155179
|
155180
|
155189
|
155190
|
155191
|
155656
|
155657
|
155658
|
155659
|
155660
|
155661
|
155691
|
155694
|
155783
|
155784
|
155785
|
155786
|
155787
|
155788
|
155789
|
155790
|
155791
|
157117
|
157118
|
157119
|
157120
|
157121
|
157122
|
157123
|
157124
|
157125
|
157126
|
157773
|
157774
|
157775
|
157776
|
157777
|
157778
|
157779
|
157780
|
157781
|
157782
|
157783