Bugzilla – Attachment 141311 Details for
Bug 31203
Cronjobs should log completion as well as logging begin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31203: Alter cronlogaction to take a hash
Bug-31203-Alter-cronlogaction-to-take-a-hash.patch (text/plain), 1.16 KB, created by
Marcel de Rooy
on 2022-10-04 15:01:18 UTC
(
hide
)
Description:
Bug 31203: Alter cronlogaction to take a hash
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2022-10-04 15:01:18 UTC
Size:
1.16 KB
patch
obsolete
>From 5b3ede5470b148d5d96bc54212da2b30fc73de5b Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 21 Jul 2022 12:43:34 +0000 >Subject: [PATCH] Bug 31203: Alter cronlogaction to take a hash >Content-Type: text/plain; charset=utf-8 > >This patch simply changes the routine to expect a hashref for info >and to log the PID as object in action logs > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Log.pm | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/C4/Log.pm b/C4/Log.pm >index 05a81f1a26..2d520013a8 100644 >--- a/C4/Log.pm >+++ b/C4/Log.pm >@@ -131,10 +131,11 @@ Logs the path and name of the calling script plus the information privided by pa > > #' > sub cronlogaction { >- my ($infos)=@_; >+ my $params = shift; >+ my $info = $params->{info}; > my $loginfo = (caller(0))[1]; >- $loginfo .= ' ' . $infos if $infos; >- logaction( 'CRONJOBS', 'Run', undef, $loginfo ) if C4::Context->preference('CronjobLog'); >+ $loginfo .= ' ' . $info if $info; >+ logaction( 'CRONJOBS', 'Run', $$, $loginfo ) if C4::Context->preference('CronjobLog'); > } > > 1; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31203
:
137960
|
137961
|
137962
|
137963
|
137983
|
138695
|
140743
|
140744
|
140745
|
140746
|
140980
|
140981
|
140982
|
140983
|
141128
| 141311 |
141312
|
141313
|
141314
|
141315