Attachment 141343 Details for Bug 22321 – Bug 22321: Update holds borrowernumber when ILL request borrowernumber changes

[patch] Bug 22321: Update holds borrowernumber when ILL request borrowernumber changes

Bug-22321-Update-holds-borrowernumber-when-ILL-req.patch (text/plain), 1.61 KB, created by Martin Renvoize (ashimema) on 2022-10-05 10:45:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-10-05 10:45:01 UTC

Size: 1.61 KB

patch

obsolete

>From 369a96fffba68f61989843cb5249998343c2f54d Mon Sep 17 00:00:00 2001
>From: Lari Taskula <lari.taskula@hypernova.fi>
>Date: Mon, 14 Feb 2022 11:16:31 +0000
>Subject: [PATCH] Bug 22321: Update holds borrowernumber when ILL request
> borrowernumber changes
>
>To test:
>1. prove t/db_dependent/Illrequests.t
>
>Signed-off-by: Magnus Enger <magnus@libriotech.no>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Illrequest.pm | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
>diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm
>index 2c38dddaad..c60c1dcdf9 100644
>--- a/Koha/Illrequest.pm
>+++ b/Koha/Illrequest.pm
>@@ -1758,8 +1758,29 @@ possibly records the fact that something happened
> sub store {
>     my ( $self, $attrs ) = @_;
> 
>+    my %updated_columns = $self->_result->get_dirty_columns;
>+
>+    my @holds;
>+    if( defined $updated_columns{'borrowernumber'} and
>+        Koha::Patrons->find( $updated_columns{'borrowernumber'} ) )
>+    {
>+        # borrowernumber has changed
>+        my $old_illreq = $self->get_from_storage;
>+        @holds = Koha::Holds->search( {
>+            borrowernumber => $old_illreq->borrowernumber,
>+            biblionumber   => $self->biblio_id,
>+        } )->as_list;
>+    }
>+
>     my $ret = $self->SUPER::store;
> 
>+    if ( scalar @holds ) {
>+        # move holds to the changed borrowernumber
>+        foreach my $hold ( @holds ) {
>+            $hold->borrowernumber( $updated_columns{'borrowernumber'} )->store;
>+        }
>+    }
>+
>     $attrs->{log_origin} = 'core';
> 
>     if ($ret && defined $attrs) {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22321: 130544 | 130545 | 130546 | 131012 | 131013 | 131055 | 131056 | 131057 | 131058 | 131059 | 138873 | 138874 | 138875 | 138876 | 138877 | 138878 | 141342 | 141343 | 141344 | 141345 | 141346 | 141347