Attachment 141414 Details for Bug 17499 – Bug 17499: (follow-up) Fix warning

[patch] Bug 17499: (follow-up) Fix warning

Bug-17499-follow-up-Fix-warning.patch (text/plain), 1.49 KB, created by Lari Taskula on 2022-10-06 12:02:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lari Taskula

Created: 2022-10-06 12:02:59 UTC

Size: 1.49 KB

patch

obsolete

>From 9eca5b3c02e7afb51f1f4fa63f4f0d2ecb6debda Mon Sep 17 00:00:00 2001
>From: Lari Taskula <lari.taskula@hypernova.fi>
>Date: Thu, 5 Nov 2020 18:26:42 +0000
>Subject: [PATCH] Bug 17499: (follow-up) Fix warning
>
>Fix warning
>
>DBIx::Class::Storage::DBI::select_single(): Query returned more than one row.
>SQL that returns multiple rows is DEPRECATED for ->find and ->single.
>
>Sponsored-by: The National Library of Finland
>
>Signed-off-by: Michal Denar <black23@gmail.com>
>---
> Koha/Patron/Message/Preference.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Patron/Message/Preference.pm b/Koha/Patron/Message/Preference.pm
>index 553085fafe..53b17011a7 100644
>--- a/Koha/Patron/Message/Preference.pm
>+++ b/Koha/Patron/Message/Preference.pm
>@@ -391,10 +391,10 @@ sub _set_message_transport_types {
>     $self->_validate_message_transport_types({ message_transport_types => $types });
>     foreach my $type (@$types) {
>         unless (exists $self->{'_message_transport_types'}->{$type}) {
>-            my $transport = Koha::Patron::Message::Transports->find({
>+            my $transport = Koha::Patron::Message::Transports->search({
>                 message_attribute_id => $self->message_attribute_id,
>                 message_transport_type => $type
>-            });
>+            })->next;
>             unless ($transport) {
>                 Koha::Exceptions::Patron::Message::Preference::NoTransportType->throw(
>                     error => 'No transport configured for '.$self->message_name.
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 17499: 63427 | 63428 | 63429 | 63430 | 63431 | 63432 | 63433 | 63434 | 63786 | 63787 | 63788 | 63789 | 63790 | 63791 | 63792 | 63793 | 63801 | 63802 | 63803 | 63804 | 63805 | 63806 | 63807 | 63808 | 63809 | 63810 | 63811 | 63812 | 63878 | 63895 | 64035 | 64036 | 64037 | 64038 | 64039 | 64040 | 64041 | 64042 | 64043 | 64044 | 64795 | 66686 | 69434 | 69435 | 69458 | 91864 | 93863 | 93865 | 93872 | 94748 | 99479 | 99634 | 99668 | 99669 | 99670 | 103441 | 103442 | 103443 | 106653 | 106654 | 106655 | 106656 | 106657 | 107612 | 107613 | 107614 | 107615 | 107616 | 113010 | 113011 | 113127 | 113129 | 113686 | 113687 | 113765 | 113766 | 113767 | 113768 | 118452 | 118453 | 119470 | 119471 | 119472 | 119473 | 119474 | 119475 | 119476 | 119477 | 119478 | 119479 | 119480 | 119481 | 119482 | 119483 | 119484 | 119485 | 119486 | 119487 | 119488 | 119489 | 119490 | 119491 | 141408 | 141409 | 141410 | 141411 | 141412 | 141413 | 141414 | 141415 | 141416 | 141417 | 141418 | 146529 | 146530 | 146531 | 146532 | 146533 | 146534 | 146535 | 146536 | 146537 | 146538 | 146539 | 146540 | 151900 | 151901 | 151902 | 151903 | 151904 | 151905 | 151906 | 151907 | 151908 | 151909 | 151910 | 151911 | 151937 | 151938 | 151939 | 151940 | 151941 | 151942 | 151943 | 151944 | 151945 | 151946 | 151947 | 151948 | 155365 | 155366 | 155367 | 155368 | 155369 | 155370 | 155371 | 155372 | 155373 | 155374 | 155375 | 155376