Bugzilla – Attachment 141434 Details for
Bug 17170
Add the ability to create 'saved searches' for use as filters when searching the catalog
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17170: (QA follow-up) Improve model structure
Bug-17170-QA-follow-up-Improve-model-structure.patch (text/plain), 4.12 KB, created by
Tomás Cohen Arazi (tcohen)
on 2022-10-06 14:28:09 UTC
(
hide
)
Description:
Bug 17170: (QA follow-up) Improve model structure
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-10-06 14:28:09 UTC
Size:
4.12 KB
patch
obsolete
>From 5f09cf4ae1184568a1164234f4ca0b044156b4f5 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 4 Oct 2022 16:52:12 +0100 >Subject: [PATCH] Bug 17170: (QA follow-up) Improve model structure > >This feature is awesome, but it's modals all feel a bit off.. this is an >improvement to one of them, but far from perfect. > >I opt to work with Owen to create a guideline (and template) for modals going >forward and let this patchset go in as is. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > .../prog/en/modules/admin/search_filters.tt | 45 +++++++++---------- > 1 file changed, 22 insertions(+), 23 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/search_filters.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/search_filters.tt >index 37f830489ab..dce6e7db98c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/search_filters.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/search_filters.tt >@@ -66,30 +66,29 @@ > </div> <!-- /.col-sm-2.col-sm-pull-10 --> > </div> <!-- /.row --> > >- <div id="edit_search_filter_modal" class="modal" role="dialog" aria-hidden="true"> >- <div class="modal-dialog"> >- <div class="modal-content"> >- <div class="modal-header"> >- <button type="button" class="closebtn" data-dismiss="modal" aria-hidden="true">Ã</button> >- <h3 id="search_filters_label">Edit filter: <span id="filter_edit_modal_name"></span</h3> >+ <div id="edit_search_filter_modal" class="modal fase" role="dialog" aria-hidden="true" aria-labelledby="edit_search_filter_modal_label"> >+ <div class="modal-dialog" role="document"> >+ <div class="modal-content"> >+ <div class="modal-header"> >+ <button type="button" class="closebtn" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">×</span></button> >+ <h4 class="modal-title" id="edit_search_filter_modal_label">Edit filter</h4> >+ </div> >+ <div class="modal-body"> >+ <div class="form-group"> >+ <input type="hidden" id="filter_edit_id" name="filter_edit_id"> >+ <label for="filter_edit_name">Name:</label> >+ <input id="filter_edit_name" name="filter_edit_name" type="text"> >+ <label for="filter_edit_opac">Show in OPAC?</label> >+ <input type="checkbox" id="filter_edit_opac" name="filter_edit_opac"> >+ <label for="filter_edit_staff_client">Show in Staff client?</label> >+ <input type="checkbox" id="filter_edit_staff_client" name="filter_edit_staff_client"> >+ </div> >+ </div> >+ <div class="modal-footer"> >+ <button id="replace_existing_filter" type="button" class="btn btn-primary">Save</button> >+ <button class="btn btn-default cancel" href="#" data-dismiss="modal" aria-hidden="true">Cancel</button> >+ </div> > </div> >- <div class="modal-body"> >- <input type="hidden" id="filter_edit_id" name="filter_edit_id"> >- <label for="filter_edit_name">Name:</label> >- <input id="filter_edit_name" name="filter_edit_name" type="text"> >- <hr> >- <h6>Visibility:<h6> >- <label for="filter_edit_opac">Show in OPAC?</label> >- <input type="checkbox" id="filter_edit_opac" name="filter_edit_opac"> >- <label for="filter_edit_staff_client">Show in Staff client?</label> >- <input type="checkbox" id="filter_edit_staff_client" name="filter_edit_staff_client"> >- <hr> >- <a id="replace_existing_filter" class="btn btn-default btn-xs" href="#">Update</a> >- </div> >- <div class="modal-footer"> >- <a href="#" data-dismiss="modal" aria-hidden="true" class="cancel">Cancel</a> >- </div> >- </div> > </div> > </div> > >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17170
:
133263
|
133264
|
133265
|
133266
|
133267
|
133268
|
133269
|
133270
|
133361
|
133376
|
137027
|
137028
|
137029
|
137030
|
137031
|
137032
|
137033
|
137034
|
137035
|
137036
|
137186
|
137187
|
137188
|
137189
|
137190
|
137191
|
137192
|
137193
|
137194
|
137195
|
137808
|
137809
|
137810
|
137811
|
137812
|
137813
|
137814
|
137815
|
137816
|
137817
|
138505
|
138506
|
138507
|
138508
|
138509
|
138510
|
138511
|
138512
|
138513
|
138514
|
139948
|
139949
|
139950
|
139951
|
139952
|
139953
|
139954
|
139955
|
139956
|
139957
|
141228
|
141229
|
141230
|
141231
|
141232
|
141233
|
141234
|
141235
|
141236
|
141237
|
141316
|
141317
|
141318
|
141319
|
141320
|
141321
|
141322
|
141323
|
141324
|
141325
|
141326
|
141327
|
141328
|
141348
|
141349
|
141350
|
141351
|
141352
|
141353
|
141354
|
141355
|
141356
|
141357
|
141358
|
141359
|
141360
|
141422
|
141423
|
141424
|
141425
|
141426
|
141427
|
141428
|
141429
|
141430
|
141431
|
141432
|
141433
|
141434
|
141435
|
141436
|
141437
|
141438
|
141461
|
141462
|
142365
|
142367
|
142368
|
142369
|
142370
|
142371
|
142372
|
142373
|
142374
|
142375
|
142376
|
142377
|
142378
|
142379
|
142380
|
142381
|
142382
|
142383
|
142384
|
142385
|
142494
|
142498