Bugzilla – Attachment 141438 Details for
Bug 17170
Add the ability to create 'saved searches' for use as filters when searching the catalog
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17170: (QA follow-up) Escape things, make them translatable
Bug-17170-QA-follow-up-Escape-things-make-them-tra.patch (text/plain), 3.01 KB, created by
Tomás Cohen Arazi (tcohen)
on 2022-10-06 14:28:43 UTC
(
hide
)
Description:
Bug 17170: (QA follow-up) Escape things, make them translatable
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-10-06 14:28:43 UTC
Size:
3.01 KB
patch
obsolete
>From 6eda8dec47d084ad4a3910ff640dc3222d2a9334 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 6 Oct 2022 10:58:53 -0300 >Subject: [PATCH] Bug 17170: (QA follow-up) Escape things, make them > translatable > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > .../prog/en/modules/admin/search_filters.tt | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/search_filters.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/search_filters.tt >index 13051774265..b54b7c6f550 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/search_filters.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/search_filters.tt >@@ -140,15 +140,15 @@ > "data": function( row, meta, val, type ) { > let filter = row; > let filter_buttons = '<a class="btn btn-default btn-xs edit_filter" onclick="edit_filter(this)"'; >- filter_buttons += ' data-filter_id="'+ filter.search_filter_id; >- filter_buttons += '" data-filter_name="'+ filter.name; >- filter_buttons += '" data-filter_opac="'+ filter.opac; >- filter_buttons += '" data-filter_staff_client="'+ filter.staff_client; >- filter_buttons += '" ><i class="fa fa-pencil"></i> Edit filter</a>'; >- filter_buttons += '<a class="btn btn-default btn-xs" href="/cgi-bin/koha/catalogue/search.pl?edit_filter='+filter.search_filter_id+'"><i class="fa fa-search"></i> Edit search</a>'; >+ filter_buttons += ' data-filter_id="'+ escape_str(filter.search_filter_id); >+ filter_buttons += '" data-filter_name="'+ escape_str(filter.name); >+ filter_buttons += '" data-filter_opac="'+ escape_str(filter.opac); >+ filter_buttons += '" data-filter_staff_client="'+ escape_str(filter.staff_client); >+ filter_buttons += '" ><i class="fa fa-pencil"></i> '+_("Edit filter")+'</a>'; >+ filter_buttons += '<a class="btn btn-default btn-xs" href="/cgi-bin/koha/catalogue/search.pl?edit_filter='+encodeURIComponent(filter.search_filter_id)+'"><i class="fa fa-search"></i> '+ _("Edit search") + '</a>'; > filter_buttons += '<a class="btn btn-default btn-xs delete_filter" onclick="delete_filter(this)"'; >- filter_buttons += ' data-filter_id="'+ filter.search_filter_id; >- filter_buttons += '"><i class="fa fa-trash"></i> Delete</a>'; >+ filter_buttons += ' data-filter_id="'+ escape_str(filter.search_filter_id); >+ filter_buttons += '"><i class="fa fa-trash"></i> '+_("Delete")+'</a>'; > return filter_buttons; > }, > "searchable": false, >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17170
:
133263
|
133264
|
133265
|
133266
|
133267
|
133268
|
133269
|
133270
|
133361
|
133376
|
137027
|
137028
|
137029
|
137030
|
137031
|
137032
|
137033
|
137034
|
137035
|
137036
|
137186
|
137187
|
137188
|
137189
|
137190
|
137191
|
137192
|
137193
|
137194
|
137195
|
137808
|
137809
|
137810
|
137811
|
137812
|
137813
|
137814
|
137815
|
137816
|
137817
|
138505
|
138506
|
138507
|
138508
|
138509
|
138510
|
138511
|
138512
|
138513
|
138514
|
139948
|
139949
|
139950
|
139951
|
139952
|
139953
|
139954
|
139955
|
139956
|
139957
|
141228
|
141229
|
141230
|
141231
|
141232
|
141233
|
141234
|
141235
|
141236
|
141237
|
141316
|
141317
|
141318
|
141319
|
141320
|
141321
|
141322
|
141323
|
141324
|
141325
|
141326
|
141327
|
141328
|
141348
|
141349
|
141350
|
141351
|
141352
|
141353
|
141354
|
141355
|
141356
|
141357
|
141358
|
141359
|
141360
|
141422
|
141423
|
141424
|
141425
|
141426
|
141427
|
141428
|
141429
|
141430
|
141431
|
141432
|
141433
|
141434
|
141435
|
141436
|
141437
|
141438
|
141461
|
141462
|
142365
|
142367
|
142368
|
142369
|
142370
|
142371
|
142372
|
142373
|
142374
|
142375
|
142376
|
142377
|
142378
|
142379
|
142380
|
142381
|
142382
|
142383
|
142384
|
142385
|
142494
|
142498