Bugzilla – Attachment 141483 Details for
Bug 31469
log4perl.conf: Plack logfiles need %n in conversionpattern
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31469: log4perl.conf: Add %n to conversionpattern for Plack
Bug-31469-log4perlconf-Add-n-to-conversionpattern-.patch (text/plain), 7.39 KB, created by
Martin Renvoize (ashimema)
on 2022-10-07 10:00:43 UTC
(
hide
)
Description:
Bug 31469: log4perl.conf: Add %n to conversionpattern for Plack
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-10-07 10:00:43 UTC
Size:
7.39 KB
patch
obsolete
>From 5c0e37e398b737ba0582f7e741faa7bd4dd649b1 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 29 Sep 2022 07:51:33 +0000 >Subject: [PATCH] Bug 31469: log4perl.conf: Add %n to conversionpattern for > Plack > >The PLACKOPAC, PLACKAPI and PLACKINTRANET appenders still need %n >(i.e. a newline). Note that this patch does not add %l since it >is a bit confusing because it adds a lot of Plack internal noise like: > [2022/09/29 08:51:34] [WARN] Test mainpage CGI::Compile::ROOT::usr_share_koha_mainpage_2epl::__ANON__ /usr/share/koha/mainpage.pl (49) > >The patch is a result of: > git grep -l "log4perl.appender.PLACK" | xargs sed -i -e"/ConversionPattern/ s/%m$/%m%n/" > >Test plan: >First run: sed -i -e"/ConversionPattern/ s/%m$/%m%n/" /etc/koha/sites/[YOUR_CLONE]/log4perl.conf >Edit that file, change PLACKOPAC to debug level like: > log4perl.logger.plack-opac = DEBUG, PLACKOPAC >Restart. >Hit an OPAC page twice. >Check plack-opac logfile and verify that it contains a newline between last two messages like: > [2022/09/29 08:04:30] [DEBUG] kohaversion : 22.0600054 > [2022/09/29 08:04:42] [DEBUG] kohaversion : 22.0600054 > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > debian/koha-common.postinst | 6 +++--- > debian/koha-core.postinst | 6 +++--- > debian/templates/log4perl-site.conf.in | 6 +++--- > etc/log4perl.conf | 6 +++--- > 4 files changed, 12 insertions(+), 12 deletions(-) > >diff --git a/debian/koha-common.postinst b/debian/koha-common.postinst >index f8914fb25d..2540ea654f 100644 >--- a/debian/koha-common.postinst >+++ b/debian/koha-common.postinst >@@ -198,7 +198,7 @@ log4perl.appender.PLACKOPAC=Log::Log4perl::Appender::File > log4perl.appender.PLACKOPAC.filename=/var/log/koha/$site/plack-opac-error.log > log4perl.appender.PLACKOPAC.mode=append > log4perl.appender.PLACKOPAC.layout=PatternLayout >-log4perl.appender.PLACKOPAC.layout.ConversionPattern=[%d] [%p] %m >+log4perl.appender.PLACKOPAC.layout.ConversionPattern=[%d] [%p] %m%n > log4perl.appender.PLACKOPAC.utf8=1 > > EOF >@@ -214,7 +214,7 @@ log4perl.appender.PLACKAPI=Log::Log4perl::Appender::File > log4perl.appender.PLACKAPI.filename=/var/log/koha/$site/plack-api-error.log > log4perl.appender.PLACKAPI.mode=append > log4perl.appender.PLACKAPI.layout=PatternLayout >-log4perl.appender.PLACKAPI.layout.ConversionPattern=[%d] [%p] %m >+log4perl.appender.PLACKAPI.layout.ConversionPattern=[%d] [%p] %m%n > log4perl.appender.PLACKAPI.utf8=1 > > EOF >@@ -230,7 +230,7 @@ log4perl.appender.PLACKINTRANET=Log::Log4perl::Appender::File > log4perl.appender.PLACKINTRANET.filename=/var/log/koha/$site/plack-intranet-error.log > log4perl.appender.PLACKINTRANET.mode=append > log4perl.appender.PLACKINTRANET.layout=PatternLayout >-log4perl.appender.PLACKINTRANET.layout.ConversionPattern=[%d] [%p] %m >+log4perl.appender.PLACKINTRANET.layout.ConversionPattern=[%d] [%p] %m%n > log4perl.appender.PLACKINTRANET.utf8=1 > > EOF >diff --git a/debian/koha-core.postinst b/debian/koha-core.postinst >index 661b7bd016..8162c00870 100644 >--- a/debian/koha-core.postinst >+++ b/debian/koha-core.postinst >@@ -198,7 +198,7 @@ log4perl.appender.PLACKOPAC=Log::Log4perl::Appender::File > log4perl.appender.PLACKOPAC.filename=/var/log/koha/$site/plack-opac-error.log > log4perl.appender.PLACKOPAC.mode=append > log4perl.appender.PLACKOPAC.layout=PatternLayout >-log4perl.appender.PLACKOPAC.layout.ConversionPattern=[%d] [%p] %m >+log4perl.appender.PLACKOPAC.layout.ConversionPattern=[%d] [%p] %m%n > log4perl.appender.PLACKOPAC.utf8=1 > > EOF >@@ -214,7 +214,7 @@ log4perl.appender.PLACKAPI=Log::Log4perl::Appender::File > log4perl.appender.PLACKAPI.filename=/var/log/koha/$site/plack-api-error.log > log4perl.appender.PLACKAPI.mode=append > log4perl.appender.PLACKAPI.layout=PatternLayout >-log4perl.appender.PLACKAPI.layout.ConversionPattern=[%d] [%p] %m >+log4perl.appender.PLACKAPI.layout.ConversionPattern=[%d] [%p] %m%n > log4perl.appender.PLACKAPI.utf8=1 > > EOF >@@ -230,7 +230,7 @@ log4perl.appender.PLACKINTRANET=Log::Log4perl::Appender::File > log4perl.appender.PLACKINTRANET.filename=/var/log/koha/$site/plack-intranet-error.log > log4perl.appender.PLACKINTRANET.mode=append > log4perl.appender.PLACKINTRANET.layout=PatternLayout >-log4perl.appender.PLACKINTRANET.layout.ConversionPattern=[%d] [%p] %m >+log4perl.appender.PLACKINTRANET.layout.ConversionPattern=[%d] [%p] %m%n > log4perl.appender.PLACKINTRANET.utf8=1 > > EOF >diff --git a/debian/templates/log4perl-site.conf.in b/debian/templates/log4perl-site.conf.in >index a95ab73163..9c0339a99a 100644 >--- a/debian/templates/log4perl-site.conf.in >+++ b/debian/templates/log4perl-site.conf.in >@@ -44,7 +44,7 @@ log4perl.appender.PLACKOPAC=Log::Log4perl::Appender::File > log4perl.appender.PLACKOPAC.filename=__LOG_DIR__/plack-opac-error.log > log4perl.appender.PLACKOPAC.mode=append > log4perl.appender.PLACKOPAC.layout=PatternLayout >-log4perl.appender.PLACKOPAC.layout.ConversionPattern=[%d] [%p] %m >+log4perl.appender.PLACKOPAC.layout.ConversionPattern=[%d] [%p] %m%n > log4perl.appender.PLACKOPAC.utf8=1 > > log4perl.logger.plack-api = WARN, PLACKAPI >@@ -52,7 +52,7 @@ log4perl.appender.PLACKAPI=Log::Log4perl::Appender::File > log4perl.appender.PLACKAPI.filename=__LOG_DIR__/plack-api-error.log > log4perl.appender.PLACKAPI.mode=append > log4perl.appender.PLACKAPI.layout=PatternLayout >-log4perl.appender.PLACKAPI.layout.ConversionPattern=[%d] [%p] %m >+log4perl.appender.PLACKAPI.layout.ConversionPattern=[%d] [%p] %m%n > log4perl.appender.PLACKAPI.utf8=1 > > log4perl.logger.plack-intranet = WARN, PLACKINTRANET >@@ -60,5 +60,5 @@ log4perl.appender.PLACKINTRANET=Log::Log4perl::Appender::File > log4perl.appender.PLACKINTRANET.filename=__LOG_DIR__/plack-intranet-error.log > log4perl.appender.PLACKINTRANET.mode=append > log4perl.appender.PLACKINTRANET.layout=PatternLayout >-log4perl.appender.PLACKINTRANET.layout.ConversionPattern=[%d] [%p] %m >+log4perl.appender.PLACKINTRANET.layout.ConversionPattern=[%d] [%p] %m%n > log4perl.appender.PLACKINTRANET.utf8=1 >diff --git a/etc/log4perl.conf b/etc/log4perl.conf >index 6736c3d1ba..a07d139d96 100644 >--- a/etc/log4perl.conf >+++ b/etc/log4perl.conf >@@ -43,7 +43,7 @@ log4perl.appender.PLACKOPAC=Log::Log4perl::Appender::File > log4perl.appender.PLACKOPAC.filename=__LOG_DIR__/plack-opac-error.log > log4perl.appender.PLACKOPAC.mode=append > log4perl.appender.PLACKOPAC.layout=PatternLayout >-log4perl.appender.PLACKOPAC.layout.ConversionPattern=[%d] [%p] %m >+log4perl.appender.PLACKOPAC.layout.ConversionPattern=[%d] [%p] %m%n > log4perl.appender.PLACKOPAC.utf8=1 > > log4perl.logger.plack-api = WARN, PLACKAPI >@@ -51,7 +51,7 @@ log4perl.appender.PLACKAPI=Log::Log4perl::Appender::File > log4perl.appender.PLACKAPI.filename=__LOG_DIR__/plack-api-error.log > log4perl.appender.PLACKAPI.mode=append > log4perl.appender.PLACKAPI.layout=PatternLayout >-log4perl.appender.PLACKAPI.layout.ConversionPattern=[%d] [%p] %m >+log4perl.appender.PLACKAPI.layout.ConversionPattern=[%d] [%p] %m%n > log4perl.appender.PLACKAPI.utf8=1 > > log4perl.logger.plack-intranet = WARN, PLACKINTRANET >@@ -59,5 +59,5 @@ log4perl.appender.PLACKINTRANET=Log::Log4perl::Appender::File > log4perl.appender.PLACKINTRANET.filename=__LOG_DIR__/plack-intranet-error.log > log4perl.appender.PLACKINTRANET.mode=append > log4perl.appender.PLACKINTRANET.layout=PatternLayout >-log4perl.appender.PLACKINTRANET.layout.ConversionPattern=[%d] [%p] %m >+log4perl.appender.PLACKINTRANET.layout.ConversionPattern=[%d] [%p] %m%n > log4perl.appender.PLACKINTRANET.utf8=1 >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31469
:
141079
| 141483