Bugzilla – Attachment 14166 Details for
Bug 9021
Add SMS via email as an alternative to SMS services via SMS::Send drivers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers - Followup
Bug-9021---Add-SMS-via-email-as-an-alternative-to-.patch (text/plain), 3.62 KB, created by
Kyle M Hall (khall)
on 2012-12-17 16:06:34 UTC
(
hide
)
Description:
Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers - Followup
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2012-12-17 16:06:34 UTC
Size:
3.62 KB
patch
obsolete
>From 33731df975e6ad8e24cf12eb9e0e265b193678ae Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 17 Dec 2012 11:06:41 -0500 >Subject: [PATCH] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers - Followup > >--- > .../opac-tmpl/prog/en/modules/opac-messaging.tt | 25 +++++++++++++++++++- > opac/opac-messaging.pl | 9 ++++++- > 2 files changed, 32 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-messaging.tt >index 8f8e6b4..ecc167e 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-messaging.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-messaging.tt >@@ -143,8 +143,31 @@ > </tr> > [% END %] > </table> >-[% IF ( SMSSendDriver ) %]<ol><li><label for="SMSnumber">SMS number:</label> <input type="text" id="SMSnumber" name="SMSnumber" value="[% SMSnumber %]" /></li></ol>[% END %] > >+ [% IF ( SMSSendDriver ) %] >+ <ol><li><label>Notice:</label>Some charges for text messages may be incurred when using this service. Please check with your mobile service provider if you have questions.</li></ol> >+ <ol><li> >+ <label for="SMSnumber">SMS number:</label> <input type="text" id="SMSnumber" name="SMSnumber" value="[% SMSnumber %]" /> >+ <i>Please enter numbers only. <b>(123) 456-7890</b> would be entered as <b>1234567890</b>.</i> >+ </li></ol> >+ [% END %] >+ >+ [% IF ( SMSSendDriver == 'Email' ) %] >+ <ol><li> >+ <label for="sms_provider_id">SMS provider:</label> >+ <select id="sms_provider_id" name="sms_provider_id"/> >+ <option value="">Unknown</option> >+ [% FOREACH s IN sms_providers %] >+ [% IF s.id == sms_provider_id %] >+ <option value="[% s.id %]" selected="selected">[% s.name %]</option> >+ [% ELSE %] >+ <option value="[% s.id %]">[% s.name %]</option> >+ [% END %] >+ [% END %] >+ </select> >+ <i>Please contact a library staff member if you are unsure of your mobile service provider, or you do not see your provider in this list.</i> >+ </li></ol> >+ [% END %] > </fieldset> > > <fieldset class="action"> >diff --git a/opac/opac-messaging.pl b/opac/opac-messaging.pl >index dc244db..e42d8e8 100755 >--- a/opac/opac-messaging.pl >+++ b/opac/opac-messaging.pl >@@ -54,7 +54,9 @@ if ( defined $query->param('modify') && $query->param('modify') eq 'yes' ) { > # If they've modified the SMS number, record it. > if ( ( defined $query->param('SMSnumber') ) && ( $query->param('SMSnumber') ne $borrower->{'mobile'} ) ) { > ModMember( borrowernumber => $borrowernumber, >- smsalertnumber => $query->param('SMSnumber') ); >+ smsalertnumber => $query->param('SMSnumber'), >+ sms_provider_id => $query->param('sms_provider_id') >+ ); > $borrower = GetMemberDetails( $borrowernumber ); > } > >@@ -70,4 +72,9 @@ $template->param( BORROWER_INFO => [ $borrower ], > SMSSendDriver => C4::Context->preference("SMSSendDriver"), > TalkingTechItivaPhone => C4::Context->preference("TalkingTechItivaPhoneNotification") ); > >+if ( C4::Context->preference("SMSSendDriver") eq 'Email' ) { >+ my @providers = Koha::SMS::Provider->all(); >+ $template->param( sms_providers => \@providers, sms_provider_id => $borrower->{'sms_provider_id'} ); >+} >+ > output_html_with_http_headers $query, $cookie, $template->output; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9021
:
13290
|
13291
|
13293
|
13294
|
14166
|
14167
|
14363
|
15685
|
15687
|
15689
|
15691
|
16628
|
17311
|
21729
|
22478
|
28488
|
29927
|
32453
|
34180
|
34181
|
35816
|
40720
|
44331
|
45152
|
46163
|
46164
|
46165
|
46168
|
46169
|
46170
|
46171
|
47128
|
47129
|
47130
|
47133
|
47134
|
47135
|
47338
|
47339
|
47814
|
47815
|
47816
|
47817
|
47818
|
47845
|
47846
|
47847
|
47848
|
47995
|
48024
|
48025
|
48026
|
48027
|
48028
|
48029
|
48030
|
48031
|
48032
|
48033
|
48034
|
48035
|
48036
|
48052
|
48053
|
48054
|
48055
|
48056
|
48057
|
48058
|
48059
|
48060
|
48061
|
48062
|
48063
|
48064
|
48065
|
48066