Attachment 141841 Details for Bug 31780 – Bug 31780: Add page-section class to audio alerts

[patch] Bug 31780: Add page-section class to audio alerts

Bug-31780-Add-page-section-class-to-audio-alerts.patch (text/plain), 6.73 KB, created by Lucas Gass (lukeg) on 2022-10-13 19:59:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2022-10-13 19:59:47 UTC

Size: 6.73 KB

patch

obsolete

>From d291631311cc8d4052eb2768fd85892342fe497a Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Thu, 13 Oct 2022 19:56:50 +0000
>Subject: [PATCH] Bug 31780: Add page-section class to audio alerts
>
>To test:
>
>1. Apply the patch and go to Administration -> Audio alerts
>2. Confirm that the screen/table look correct with the page-section class added.
>
>Note: There are some indentation changes.
>---
> .../prog/en/modules/admin/audio_alerts.tt     | 78 ++++++++++---------
> 1 file changed, 40 insertions(+), 38 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt
>index 2208ff5ef6..22879620cf 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt
>@@ -100,48 +100,50 @@
>                             [% END %]
>                         </div>
>                     [% END %]
>-                    <table id="audio-alerts-table">
>-                        <thead id="audio-alerts-table-head">
>-                            <tr>
>-                                <th>&nbsp;</th>
>-                                <th>Precedence</th>
>-                                <th>Change order</th>
>-                                <th>Selector</th>
>-                                <th>Sound</th>
>-                                <th>&nbsp;</th>
>-                            </tr>
>-                        </thead>
>-
>-                        <tbody id="audio-alerts-table-body">
>-                            [% FOREACH a IN audio_alerts %]
>+                    <div class="page-section">
>+                        <table id="audio-alerts-table">
>+                            <thead id="audio-alerts-table-head">
>                                 <tr>
>-                                    <td><input type="checkbox" name="delete" value="[% a.id | html %]" /></td>
>-                                    <td>[% a.precedence | html %]</td>
>-                                    <td style="white-space:nowrap;">
>-                                        <a title="Move alert up" href="audio_alerts.pl?action=move&amp;where=up&amp;id=[% a.id | html %]">
>-                                            <i class="fa fa-arrow-up fa-lg order-control"></i>
>-                                        </a>
>+                                    <th>&nbsp;</th>
>+                                    <th>Precedence</th>
>+                                    <th>Change order</th>
>+                                    <th>Selector</th>
>+                                    <th>Sound</th>
>+                                    <th>&nbsp;</th>
>+                                </tr>
>+                            </thead>
> 
>-                                        <a title="Move alert to top" href="audio_alerts.pl?action=move&amp;where=top&amp;id=[% a.id | html %]">
>-                                            <i class="fa fa-arrow-up fa-lg overline order-control"></i>
>-                                        </a>
>+                            <tbody id="audio-alerts-table-body">
>+                                [% FOREACH a IN audio_alerts %]
>+                                    <tr>
>+                                        <td><input type="checkbox" name="delete" value="[% a.id | html %]" /></td>
>+                                        <td>[% a.precedence | html %]</td>
>+                                        <td style="white-space:nowrap;">
>+                                            <a title="Move alert up" href="audio_alerts.pl?action=move&amp;where=up&amp;id=[% a.id | html %]">
>+                                                <i class="fa fa-arrow-up fa-lg order-control"></i>
>+                                            </a>
> 
>-                                        <a title="Move alert to bottom" href="audio_alerts.pl?action=move&amp;where=bottom&amp;id=[% a.id | html %]">
>-                                            <i class="fa fa-arrow-down fa-lg underline order-control"></i>
>-                                        </a>
>+                                            <a title="Move alert to top" href="audio_alerts.pl?action=move&amp;where=top&amp;id=[% a.id | html %]">
>+                                                <i class="fa fa-arrow-up fa-lg overline order-control"></i>
>+                                            </a>
> 
>-                                        <a title="Move alert down" href="audio_alerts.pl?action=move&amp;where=down&amp;id=[% a.id | html %]">
>-                                            <i class="fa fa-arrow-down fa-lg order-control"></i>
>-                                        </a>
>-                                    </td>
>-                                    <td>[% a.selector | html %]</td>
>-                                    <td>[% a.sound | html %]</td>
>-                                    <td>
>-                                        <a class="btn btn-default btn-xs edit" data-soundid="[% a.id | html %]" data-precedence="[% a.precedence | html %]" data-selector="[% a.selector | html %]" data-sound="[% a.sound | html %]"><i class="fa fa-pencil"></i> Edit</a></td>
>-                                </tr>
>-                            [% END %]
>-                        </tbody>
>-                    </table>
>+                                            <a title="Move alert to bottom" href="audio_alerts.pl?action=move&amp;where=bottom&amp;id=[% a.id | html %]">
>+                                                <i class="fa fa-arrow-down fa-lg underline order-control"></i>
>+                                            </a>
>+
>+                                            <a title="Move alert down" href="audio_alerts.pl?action=move&amp;where=down&amp;id=[% a.id | html %]">
>+                                                <i class="fa fa-arrow-down fa-lg order-control"></i>
>+                                            </a>
>+                                        </td>
>+                                        <td>[% a.selector | html %]</td>
>+                                        <td>[% a.sound | html %]</td>
>+                                        <td>
>+                                            <a class="btn btn-default btn-xs edit" data-soundid="[% a.id | html %]" data-precedence="[% a.precedence | html %]" data-selector="[% a.selector | html %]" data-sound="[% a.sound | html %]"><i class="fa fa-pencil"></i> Edit</a></td>
>+                                    </tr>
>+                                [% END %]
>+                            </tbody>
>+                        </table>
>+                    </div> 
> 
>                     <p>
>                         <button id="delete-alerts" type="submit" class="btn btn-default disabled"><i class="fa fa-trash"></i> Delete selected alerts</button>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31780: 141841 | 141847 | 141893