Attachment 141864 Details for Bug 31785 – Bug 31785: Fix for adding non-public library

[patch] Bug 31785: Fix for adding non-public library

Bug-31785-Fix-for-adding-non-public-library.patch (text/plain), 1.28 KB, created by Marcel de Rooy on 2022-10-14 07:48:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2022-10-14 07:48:14 UTC

Size: 1.28 KB

patch

obsolete

>From a41b64dbf18e3f95a0ab5ca08e06c1875290dc22 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 14 Oct 2022 07:42:26 +0000
>Subject: [PATCH] Bug 31785: Fix for adding non-public library
>Content-Type: text/plain; charset=utf-8
>
>The code in admin/branches.pl changed a 0 to undef which is not
>desirable for booleans.
>A similar fix was already present for pickup_location.
>This may need a bit more thought (somewhere else!).
>
>Test plan:
>Add a new branch with pickup location No, public No.
>Check.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> admin/branches.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/admin/branches.pl b/admin/branches.pl
>index 17b6a47d3c..0b3a12f97a 100755
>--- a/admin/branches.pl
>+++ b/admin/branches.pl
>@@ -128,7 +128,7 @@ if ( $op eq 'add_form' ) {
>                 branchcode => $branchcode,
>                 (
>                     map {
>-                        $_ eq 'pickup_location' # Don't fallback to undef/NULL, default is 1 in DB
>+                        /^(pickup_location|public)$/ # Don't fallback to undef for those fields
>                           ? ( $_ => scalar $input->param($_) )
>                           : ( $_ => scalar $input->param($_) || undef )
>                     } @fields
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31785: 141863 | 141864 | 141868 | 141897 | 141898