Attachment 141866 Details for Bug 31437 – Revert "Bug 30718: (follow-up) index_records is called more times than we thought"

[patch] Revert "Bug 30718: (follow-up) index_records is called more times than we thought"

Revert-Bug-30718-follow-up-indexrecords-is-called-.patch (text/plain), 1.69 KB, created by Jonathan Druart on 2022-10-14 09:07:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-10-14 09:07:31 UTC

Size: 1.69 KB

patch

obsolete

>From a08f6aef3ed44262f6f4cf10ebd9d268599b40b8 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 14 Oct 2022 10:57:30 +0200
>Subject: [PATCH] Revert "Bug 30718: (follow-up) index_records is called more
> times than we thought"
>
>This reverts commit 35165e5f13ec11a62dea7f6b129f7f07c7ecb7f4.
>
>https://bugs.koha-community.org/show_bug.cgi?id=31437
>---
> t/db_dependent/Koha/SearchEngine/Indexer.t | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/Koha/SearchEngine/Indexer.t b/t/db_dependent/Koha/SearchEngine/Indexer.t
>index c593d03eda1..5dca8c7a77a 100755
>--- a/t/db_dependent/Koha/SearchEngine/Indexer.t
>+++ b/t/db_dependent/Koha/SearchEngine/Indexer.t
>@@ -223,10 +223,10 @@ subtest 'Test indexer calls' => sub {
> 
>         warnings_are{
>             ModItemTransfer( $item->itemnumber, $item2->homebranch, $item->homebranch,'Manual');
>-        } [$engine,"Koha::Item",$engine,"Koha::Item"], "index_records is called twice for $engine when calling ModItemTransfer";
>+        } [$engine,"Koha::Item"], "index_records is called for $engine when calling ModItemTransfer";
>         warnings_are{
>-            ModItemTransfer( $item->itemnumber, $item->homebranch, $item2->homebranch,'Manual',{ skip_record_index => 1 });
>-        } [$engine,"Koha::Item"], "index_records is called once for $engine when calling ModItemTransfer with skip_record_index";
>+            ModItemTransfer( $item->itemnumber, $item->homebranch, $item2->homebranch,'Manual',{skip_record_index=>1});
>+        } undef, "index_records is not called for $engine when calling ModItemTransfer with skip_record_index";
> 
>         warnings_are{
>             $item->delete();
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 31437: 141866 | 141867 | 141874 | 141875