Attachment 141868 Details for Bug 31785 – Bug 31785: (follow-up) Fix modify operation too

[patch] Bug 31785: (follow-up) Fix modify operation too

Bug-31785-follow-up-Fix-modify-operation-too.patch (text/plain), 1.04 KB, created by Marcel de Rooy on 2022-10-14 09:08:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2022-10-14 09:08:51 UTC

Size: 1.04 KB

patch

obsolete

>From fef9115d9b9ffd6623dddba82ef2559849b30132 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 14 Oct 2022 09:07:14 +0000
>Subject: [PATCH] Bug 31785: (follow-up) Fix modify operation too
>Content-Type: text/plain; charset=utf-8
>
>Test plan:
>Enable SQL strict mode (koha-conf).
>Modify branch, set Public to No.
>Check.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> admin/branches.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/admin/branches.pl b/admin/branches.pl
>index 0b3a12f97a..112ca421d3 100755
>--- a/admin/branches.pl
>+++ b/admin/branches.pl
>@@ -87,7 +87,7 @@ if ( $op eq 'add_form' ) {
>     if ($is_a_modif) {
>         my $library = Koha::Libraries->find($branchcode);
>         for my $field (@fields) {
>-            if ( $field eq 'pickup_location' ) {
>+            if( $field =~ /^(pickup_location|public)$/  ) {
>                 # Don't fallback to undef/NULL, default is 1 in DB
>                 $library->$field( scalar $input->param($field) );
>             } else {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31785: 141863 | 141864 | 141868 | 141897 | 141898