Bugzilla – Attachment 141873 Details for
Bug 29554
neworderempty.pl may create records with biblioitems.itemtype NULL
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29554: Do not hide display of itemtypes on neworderempty
Bug-29554-Do-not-hide-display-of-itemtypes-on-newo.patch (text/plain), 1.68 KB, created by
Slava Shishkin
on 2022-10-14 11:43:57 UTC
(
hide
)
Description:
Bug 29554: Do not hide display of itemtypes on neworderempty
Filename:
MIME Type:
Creator:
Slava Shishkin
Created:
2022-10-14 11:43:57 UTC
Size:
1.68 KB
patch
obsolete
>From 2e650fdd0cb48c8120b66a4c5c6318f674d2801b Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 22 Nov 2021 13:00:57 +0000 >Subject: [PATCH] Bug 29554: Do not hide display of itemtypes on neworderempty > >Hiding the list may lead to biblioitems.itemtype being NULL. >We do not want that, since 942$c is mandatory. > >Test plan: >Create basket and set 'create items when' to receiving or >cataloging. >Create order from new empty record. >Check biblioitems.itemtype of created biblio. >Without this patch, it would have been NULL like this: > select biblionumber,title from biblio; > | 7 | Test 3 | > select biblionumber,itemtype from biblioitems; > | 7 | NULL | > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > acqui/neworderempty.pl | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl >index e4f8a9f175..a584ea1d11 100755 >--- a/acqui/neworderempty.pl >+++ b/acqui/neworderempty.pl >@@ -364,9 +364,7 @@ if ($basketobj->effective_create_items eq 'ordering' && !$ordernumber) { > ); > } > >-# Get the item types list, but only if item_level_itype is YES. Otherwise, it will be in the item, no need to display it in the biblio >-my @itemtypes; >-@itemtypes = Koha::ItemTypes->search->as_list unless C4::Context->preference('item-level_itypes'); >+my @itemtypes = Koha::ItemTypes->search->as_list; > > if ( defined $from_subscriptionid ) { > # Get the last received order for this subscription >-- >2.35.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29554
:
127927
|
139117
|
140688
|
140701
|
141488
| 141873