Bugzilla – Attachment 141948 Details for
Bug 28012
Error on saving new numbering pattern
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28012: Creating numbering pattern: mark mandatory fields required
Bug-28012-Creating-numbering-pattern-mark-mandator.patch (text/plain), 2.78 KB, created by
David Nind
on 2022-10-16 20:57:58 UTC
(
hide
)
Description:
Bug 28012: Creating numbering pattern: mark mandatory fields required
Filename:
MIME Type:
Creator:
David Nind
Created:
2022-10-16 20:57:58 UTC
Size:
2.78 KB
patch
obsolete
>From 727aa76e393ef7cd4cdfd96d2adaad17ca60575b Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi> >Date: Sat, 3 Sep 2022 14:08:50 +0300 >Subject: [PATCH] Bug 28012: Creating numbering pattern: mark mandatory fields > required > >If any of these fields were missing, notably the Numbering formula >then saving the new numbering pattern silently failed, it didn't give >any error but it didn't save any new pattern either. > >Note that there is a plan to make description field optional, so even >if it currently is mandatory on the DB level we leave it optional >here (and due to people using production DB's in non-strict mode which >allows this to be optional). > >To test: > 1) After applying this patch make sure all the 3 fields must be > filled in > /cgi-bin/koha/serials/subscription-numberpatterns.pl?op=new > page and it cannot be saved without those. > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../en/modules/serials/subscription-numberpatterns.tt | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt >index 7442ba1dfa..697cf4ce09 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt >@@ -82,16 +82,18 @@ > <fieldset class="rows"> > <ol> > <li> >- <label for="label">Name:</label> >- <input type="text" id="label" name="label" value="[% label | html %]" /> >+ <label class="required" for="label">Name:</label> >+ <input type="text" id="label" name="label" value="[% label | html %]" class="required" required="required" /> >+ <span class="required">Required</span> > </li> > <li> > <label for="description">Description:</label> > <input type="text" id="description" name="description" value="[% description | html %]" size="50" /> > </li> > <li> >- <label for="numberingmethod">Numbering formula:</label> >- <input type="text" id="numberingmethod" name="numberingmethod" value="[% numberingmethod | html %]" /> >+ <label class="required" for="numberingmethod">Numbering formula:</label> >+ <input type="text" id="numberingmethod" name="numberingmethod" value="[% numberingmethod | html %]" class="required" required="required" /> >+ <span class="required">Required</span> > </li> > <li> > <label for="displayorder">Display order:</label> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28012
:
140196
|
140197
|
140322
|
140337
|
141947
|
141948
|
160248
|
160249
|
160250