Bugzilla – Attachment 141989 Details for
Bug 30588
Add the option to require 2FA setup on first staff login
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30588: (QA follow-up) Remove erroneous FIXME
Bug-30588-QA-follow-up-Remove-erroneous-FIXME.patch (text/plain), 1.11 KB, created by
Jonathan Druart
on 2022-10-17 15:06:17 UTC
(
hide
)
Description:
Bug 30588: (QA follow-up) Remove erroneous FIXME
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-10-17 15:06:17 UTC
Size:
1.11 KB
patch
obsolete
>From 0fbc80e3cea75fa3e012bed9a788de25ff08aad2 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 9 Sep 2022 09:09:48 +0000 >Subject: [PATCH] Bug 30588: (QA follow-up) Remove erroneous FIXME > >Comment speaks for itself. Look at surrounding code. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/api/v1/two_factor_auth.t | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/t/db_dependent/api/v1/two_factor_auth.t b/t/db_dependent/api/v1/two_factor_auth.t >index 63075a6925a..3a890c3d652 100755 >--- a/t/db_dependent/api/v1/two_factor_auth.t >+++ b/t/db_dependent/api/v1/two_factor_auth.t >@@ -176,8 +176,7 @@ subtest 'send_otp_token' => sub { > $tx->req->cookies( { name => 'CGISESSID', value => $session->id } ); > $tx->req->env( { REMOTE_ADDR => $remote_address } ); > >- # FIXME This is not correct They are authenticated! >- # Patron is not authenticated yet >+ # Session is still anonymous, no borrowernumber yet: Unauthorized > $t->request_ok($tx)->status_is(401); > > # Patron is partially authenticated (credentials correct) >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30588
:
138160
|
138161
|
138162
|
138163
|
138164
|
138165
|
138166
|
138191
|
138193
|
138953
|
138954
|
138955
|
138956
|
138957
|
138958
|
138959
|
138960
|
138961
|
138962
|
140365
|
140366
|
140367
|
140368
|
140369
|
140416
|
140417
|
140418
|
140419
|
140420
|
140421
|
140422
|
140423
|
140424
|
140425
|
140426
|
140427
|
140428
|
140429
|
140430
|
141978
|
141979
|
141980
|
141981
|
141982
|
141983
|
141984
|
141985
|
141986
|
141987
|
141988
|
141989
|
141990
|
141991
|
141992
|
142344
|
142345
|
142346
|
142347
|
142348
|
142349
|
142350
|
142351
|
142352
|
142353
|
142354
|
142355
|
142356
|
142357
|
142358