Bugzilla – Attachment 142101 Details for
Bug 31863
Advanced cataloging editor no longer auto-resizes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31863: Account for changelanguage element when adjusting editor height
Bug-31863-Account-for-changelanguage-element-when-.patch (text/plain), 2.13 KB, created by
Lucas Gass (lukeg)
on 2022-10-18 20:58:52 UTC
(
hide
)
Description:
Bug 31863: Account for changelanguage element when adjusting editor height
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2022-10-18 20:58:52 UTC
Size:
2.13 KB
patch
obsolete
>From 1a16dcbded344ac7d36d4c4d1e6c93aafeddbea9 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 18 Oct 2022 20:53:03 +0000 >Subject: [PATCH] Bug 31863: Account for changelanguage element when adjusting > editor height > >To test: >1. Turn on 'EnableAdvancedCatalogingEditor' >2. Go to a record with enough MARC data that it should take up the entire width of your screen, >3. The CodeMirror editor will only be 300px. >4. Resize your screen, nothing happens to the editor height >5. Apply patch >6. Look at the same record in your editor, the editor should go to the bottom of the page now. Resizing your screen should resize the editor. >7. Have some additional language packs installed, and change the language system pref so the '#changelanguage' option will appear. >8. Make sure the editor height is still being properly set. >--- > koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >index 18cafecbb2..12a0de3d9c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >@@ -1020,8 +1020,11 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr > resizeTimer = null; > > var pos = $('#editor .CodeMirror').offset(); >- $('#editor .CodeMirror').height( $(window).height() - pos.top - 24 - $('#changelanguage').height() ); // 24 is hardcoded value but works well >- >+ if ( $('#changelanguage').length ) { >+ $('#editor .CodeMirror').height( $(window).height() - pos.top - 24 - $('#changelanguage').height() ); // 24 is hardcoded value but works well >+ } else { >+ $('#editor .CodeMirror').height( $(window).height() - pos.top - 24 ); >+ } > $('.modal-body').each( function() { > $(this).height( $(window).height() * .8 - $(this).prevAll('.modal-header').height() ); > } ); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31863
:
142101
|
142112
|
142411