Attachment 142139 Details for Bug 31224 – Bug 31224: (QA follow-up) Fix syntax error

[patch] Bug 31224: (QA follow-up) Fix syntax error

Bug-31224-QA-follow-up-Fix-syntax-error.patch (text/plain), 1.69 KB, created by Martin Renvoize (ashimema) on 2022-10-19 09:20:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-10-19 09:20:37 UTC

Size: 1.69 KB

patch

obsolete

>From 6b3047a46f9ede7e76a55046d981d7439779f85c Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 13 Oct 2022 09:30:06 +0100
>Subject: [PATCH] Bug 31224: (QA follow-up) Fix syntax error
>
>---
> Koha/Biblio.pm | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
>diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm
>index f3025ed706..09f774f963 100644
>--- a/Koha/Biblio.pm
>+++ b/Koha/Biblio.pm
>@@ -105,13 +105,14 @@ type. Currently only I<MARC::Record> objects are returned.
> =cut
> 
> sub metadata_record {
>-    my ($self, $params) = @_;
>+    my ( $self, $params ) = @_;
> 
>     my $patron = $params->{patron};
> 
>     my $record = $self->metadata->record;
> 
>     if ( $params->{embed_items} or $params->{opac} ) {
>+
>         # There's need for a RecordProcessor, let's do it!
>         my @filters;
>         my $options = {
>@@ -119,12 +120,14 @@ sub metadata_record {
>             frameworkcode => $self->frameworkcode,
>         };
> 
>-        if ($params->{embed_items}) {
>+        if ( $params->{embed_items} ) {
>             push @filters, 'EmbedItems';
>-            if ($params->{opac}) {
>+            if ( $params->{opac} ) {
>                 $options->{items} = $self->items->filter_by_visible_in_opac(
>                     {
>-                        ( $params->{patron} ? patron => $params->{patron} : ())
>+                        (
>+                            $params->{patron} ? ( patron => $params->{patron} ) : ()
>+                        )
>                     }
>                 );
>             }
>@@ -148,7 +151,7 @@ sub metadata_record {
>             }
>         );
> 
>-        $rp->process( $record );
>+        $rp->process($record);
>     }
> 
>     return $record;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 31224: 138060 | 138061 | 138062 | 138063 | 138064 | 142137 | 142138 | 142139 | 142140 | 142141 | 142142 | 142143 | 161933 | 161934 | 161935 | 161936 | 161937 | 161938 | 161939 | 161940 | 161941 | 161942 | 161943 | 161944 | 173530 | 173531 | 173532 | 173533 | 173534 | 173535 | 173588 | 173597 | 173598 | 173636 | 173637 | 173638 | 173639 | 173640 | 173641 | 173642 | 173643 | 173644 | 174262 | 174263