Attachment 142144 Details for Bug 31842 – Bug 31842: Move data function to render in branches.tt

[patch] Bug 31842: Move data function to render in branches.tt

Bug-31842-Move-data-function-to-render-in-branches.patch (text/plain), 1.68 KB, created by Marcel de Rooy on 2022-10-19 11:20:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2022-10-19 11:20:04 UTC

Size: 1.68 KB

patch

obsolete

>From 98454b50c766f11746ba9b577c12d3315ca6cd2a Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 17 Oct 2022 10:32:47 +0000
>Subject: [PATCH] Bug 31842: Move data function to render in branches.tt
>Content-Type: text/plain; charset=utf-8
>
>This applies to dataTable columns: library_info, actions and
>opac_info.
>Set searchable to false for opac_info too.
>
>Test plan:
>Check if DT search for libraries works again.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>{EDIT] Reverted the data/render function change as requested
>by Jonathan. Considering the fact that dataTables or custom
>extensions do not check data.col.split as a clear bug btw.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>index dd7eace461..f4d9735f18 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>@@ -674,7 +674,7 @@ Libraries &rsaquo; Administration &rsaquo; Koha
>                         "data": function( row, type, val, meta ) {
>                             return ''; // provisional placeholder for opac_info
>                         },
>-                        "searchable": true,
>+                        "searchable": false,
>                         "visible": false,
>                         "orderable": false
>                     },
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31842: 141953 | 141993 | 142032 | 142144 | 142146 | 142148